Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in restart/initialization for C-isotope sediment fields #287

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix bug in restart/initialization for C-isotope sediment fields #287

merged 1 commit into from
Oct 18, 2023

Conversation

JorgSchwinger
Copy link
Contributor

This PR closes #285 - with this fix I get bfb identical results with C-isotopes and sediment switched on.

Copy link
Collaborator

@jmaerz jmaerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you found the source of the error. I guess, we should do some code cosmetics after all merges .... I'll allocate time for the merging latest next week (first the N-cycle into beyond-CMIP6, then master into beyond-CMIP6). After that, this can be merged into master and there, we can have a code cosmetics PR+merge :-)

Copy link
Contributor

@mvertens mvertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JorgSchwinger - thanks for tracking this down!

@JorgSchwinger JorgSchwinger merged commit 799f1d2 into NorESMhub:master Oct 18, 2023
12 checks passed
@JorgSchwinger JorgSchwinger deleted the fix_c_isotopes_rstr branch October 18, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

NorESM is no longer bfb identical after merging PR-280
3 participants