-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove science_support attribute for compsets #321
Merged
TomasTorsvik
merged 1 commit into
NorESMhub:release-1.5
from
TomasTorsvik:remove_science_support_attr
Dec 12, 2023
Merged
Remove science_support attribute for compsets #321
TomasTorsvik
merged 1 commit into
NorESMhub:release-1.5
from
TomasTorsvik:remove_science_support_attr
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BLOM/iHAMOCC compsets will no longer have science_support attributes in connection with the noresm2.1 release.
TomasTorsvik
added
iHAMOCC
Issue mainly concerns the iHAMOCC code base
BLOM
Issues mainly concerning the BLOM code base
code release
Issues related to upcoming code release or tagging
labels
Dec 8, 2023
TomasTorsvik
requested review from
gold2718,
matsbn,
mvertens,
JorgSchwinger and
jmaerz
December 8, 2023 10:53
mvertens
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomasTorsvik - thanks so much for doing this!!
gold2718
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
JorgSchwinger
approved these changes
Dec 8, 2023
matsbn
approved these changes
Dec 12, 2023
gold2718
added a commit
to NorESMhub/NorESM
that referenced
this pull request
Dec 14, 2023
Externals and fixes needed for NorESM2.1 The two major updates in this PR are: 1. Correct errors in config_compsets.xml and testlist_allactive.xml 2. Update externals with NorESM2.1 updates The details: - #483 (Update CIME tag). See PR NorESMhub/cime#65 - #484 (Remove science support for coupled compset / resolution combinations). This PR - #487 (Remove PTAERO from config_compsets.xml). This and other errors (e.g., removal of an invalid compset) are corrected in this PR - #491 (Update BLOM tag). See PR NorESMhub/BLOM#321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BLOM
Issues mainly concerning the BLOM code base
code release
Issues related to upcoming code release or tagging
iHAMOCC
Issue mainly concerns the iHAMOCC code base
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLOM/iHAMOCC compsets will no longer have science_support attributes in connection with the noresm2.1 release.
If this commit is merged, it will be tagged as
v1.5.1
on therelease-1.5
branch.closes #320