Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove science_support attribute for compsets #321

Merged

Conversation

TomasTorsvik
Copy link
Contributor

@TomasTorsvik TomasTorsvik commented Dec 8, 2023

BLOM/iHAMOCC compsets will no longer have science_support attributes in connection with the noresm2.1 release.

If this commit is merged, it will be tagged as v1.5.1 on the release-1.5 branch.

closes #320

BLOM/iHAMOCC compsets will no longer have science_support attributes in
connection with the noresm2.1 release.
@TomasTorsvik TomasTorsvik added iHAMOCC Issue mainly concerns the iHAMOCC code base BLOM Issues mainly concerning the BLOM code base code release Issues related to upcoming code release or tagging labels Dec 8, 2023
@TomasTorsvik TomasTorsvik added this to the NorESM2.1 milestone Dec 8, 2023
@TomasTorsvik TomasTorsvik self-assigned this Dec 8, 2023
Copy link
Contributor

@mvertens mvertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomasTorsvik - thanks so much for doing this!!

@jmaerz jmaerz removed their request for review December 8, 2023 11:01
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomasTorsvik TomasTorsvik merged commit 7ffeaaf into NorESMhub:release-1.5 Dec 12, 2023
6 of 12 checks passed
@TomasTorsvik TomasTorsvik deleted the remove_science_support_attr branch December 12, 2023 08:22
gold2718 added a commit to NorESMhub/NorESM that referenced this pull request Dec 14, 2023
Externals and fixes needed for NorESM2.1

The two major updates in this PR are:
1. Correct errors in config_compsets.xml and testlist_allactive.xml
2. Update externals with NorESM2.1 updates

The details:
- #483 (Update CIME tag). See PR NorESMhub/cime#65
- #484 (Remove science support for coupled compset / resolution combinations). This PR
- #487 (Remove PTAERO from config_compsets.xml). This and other errors (e.g., removal of an invalid compset) are corrected in this PR
- #491 (Update BLOM tag). See PR NorESMhub/BLOM#321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOM Issues mainly concerning the BLOM code base code release Issues related to upcoming code release or tagging iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants