Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meson and remove build with intel compiler #324

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

TomasTorsvik
Copy link
Contributor

The build with intel compiler seems to be permanently broken, so all PRs to the main repository produce CI errors. The setup for intel compilers is linked to specific version and not straight forward to update. Unless someone has time to dig into the origin of these errors and preferably come up with a generic way to keep this up to date, I suggest to remove intel compiler tests from the CI test procedure,

@TomasTorsvik TomasTorsvik self-assigned this Dec 14, 2023
@TomasTorsvik TomasTorsvik added the CI/meson Issues related to CI builds and/or meson label Dec 14, 2023
@TomasTorsvik TomasTorsvik linked an issue Dec 14, 2023 that may be closed by this pull request
@TomasTorsvik
Copy link
Contributor Author

Now the CI build goes through without warnings, and sometimes without errors. The "Test code" step sometimes fails randomly, but usually goes through on 2nd try.

Copy link
Contributor

@JorgSchwinger JorgSchwinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really competent to review this PR, I was never involved in setting anything up regarding the CI. But I agree, if we can't get the intel compiler to run for the CI test, it should be removed.

@TomasTorsvik
Copy link
Contributor Author

It seems fortran-lang/setup-fortran provides a solution for the ifort compiler, but there is still a problem to link ifort with netCDF. It should be possible somehow. I will leave this PR open for a while longer and see if we can find a solution.

@TomasTorsvik
Copy link
Contributor Author

TomasTorsvik commented Jan 11, 2024

It seems ifort is deprecated in favor of ifx. Probably ifort will still be around for years to come on our existing HPCs, but perhaps not on new systems.
https://www.intel.com/content/www/us/en/developer/articles/release-notes/oneapi-fortran-compiler-release-notes.html

@TomasTorsvik
Copy link
Contributor Author

@matsbn @JorgSchwinger @jmaerz @milicak
I tried again to get ifort or ifx to work with the CI test framewok, but no success. I suggest to remove (or comment out) testing with intel compilers. Maybe we can discuss this on our next blom-core meeting?

Copy link
Contributor

@matsbn matsbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. Looks fine. We can reintroduce intel compiler if we later finds a working solution.

@TomasTorsvik TomasTorsvik merged commit 354a142 into NorESMhub:master Feb 13, 2024
6 checks passed
@TomasTorsvik TomasTorsvik deleted the update-ci branch February 13, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/meson Issues related to CI builds and/or meson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI on gitHub: build with intel compiler not working
3 participants