-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update meson and remove build with intel compiler #324
Conversation
Now the CI build goes through without warnings, and sometimes without errors. The "Test code" step sometimes fails randomly, but usually goes through on 2nd try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really competent to review this PR, I was never involved in setting anything up regarding the CI. But I agree, if we can't get the intel compiler to run for the CI test, it should be removed.
It seems fortran-lang/setup-fortran provides a solution for the |
It seems |
@matsbn @JorgSchwinger @jmaerz @milicak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this. Looks fine. We can reintroduce intel compiler if we later finds a working solution.
The build with intel compiler seems to be permanently broken, so all PRs to the main repository produce CI errors. The setup for intel compilers is linked to specific version and not straight forward to update. Unless someone has time to dig into the origin of these errors and preferably come up with a generic way to keep this up to date, I suggest to remove intel compiler tests from the CI test procedure,