-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lon,lat info in iHAMOCC output to more comply to cdo commands #355
Conversation
Hi @YanchunHe , @TomasTorsvik made me aware that you might want to skim over these changes as well, since it might affect the way you build the cmorization scripts. If this is a real issue, let me/us know. Essentially, I/we want to add the longitude and latitude information (thus far only stored in the respective gridfile) into each output file so that it becomes easier to use cdo commands on the fly when doing some quick investigations of raw output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I would almost be in favor of adding the lat/lon vertices, too. For atmosphere-ocean fluxes conservative remapping is something one might want to do.... But does not need to be at this stage.
Hi @JorgSchwinger , yeah, I wasn't sure about it - it means adding 4 more fields per file on top of the lon,lat info that I already added. I will look up the recipe that I used for conservative remapping - I post it here and we can then re-consider the implementation (I vaguely remember that some re-ordering of the corners would be needed - I don't know the reason, why they currently have the order as they have in the gridfile - is there any particular reason that you are aware of? - that was holding me a bit back) |
I'm not aware of any reason for the ordering. But also it's not a very high priority I would say. Usually when calculating total fluxes you want do this on a time-series of files, so you anyway have to combine several files. So I clearly see more application for the lat/lon. |
Dear @JorgSchwinger and @TomasTorsvik , here some recipe that can be used for conservative regridding (done with output after including the changes, while it would add a few more steps with the old output): Scenario, when one has stuff on a different grid than BLOM (note that I have an alias set for the gridfile):
or some simple conservative regridding to a regular grid:
I hope this helps in the future. |
@YanchunHe , @TomasTorsvik , any objections from your side on this PR? - otherwise I would like to merge it latest at the end of the week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmaerz - Thanks! This looks fine to me.
Sorry for the late response. It does not have impact on the cmorization tools. In principle, the CDO should be able to combine merging lat/lon to the data and remap without having intermediate output, for example:
However, seems that the So I don't have any objections to have plat/plon directly in the HAMOCC output. |
@TomasTorsvik , if possible/applicable, this PR could also be merged into the v1.6.x release. |
I will make a v1.6.1 release on |
Hi @JorgSchwinger and @TomasTorsvik , after listing up #340, I thought it might be useful to integrate the cdo-compatibility already now to make more use of the
v1.6.0+
(by merging this enhancement also intov1.6.0
).With this PR, it becomes possible to e.g. performing a simple regridding:
For a conservative regridding, we would also need to add the cell corners in the output (while I once had issues with the order, BLOM has them in the grid file, if I remember correctly). If that is wished, I can try to incorporate this as well - while I see this use case less often. It runs through with the
GLB_COMPFLAG
(after moving to the xml-list by Mariana now reachable viaGLB_COMPFLAG@DIABGC
), but at least ncview doesn't like the output (as in it doesn't show the output as usual - not sure, if this is the typical behavior).