-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature channel #78
Feature channel #78
Conversation
Bring in upstream changes including meson build and module files
…ttings for Betzy.
…ography replicable.
The pull request should finally be ready. The branch is updated with the latest master, so no more conflicts and the code is tested with NorESM. |
Mats pointed out some mistakes in OpenMP syntax and random number generation. Those are now fixed and the channel setup is verified to produce the same results with and without OpenMP. I also discovered the following behavior linked to a combination of OpenMP/pnetcdf/compressed output on Betzy OpenMP disabled + pnetcdf + uncompressed restart format → works OpenMP disabled + pnetcdf + compressed restart format → works The recommendation is to either run without OpenMP or with OpenMP + pnetcdf + uncompressed restart. Curiously, the compressed output format does not cause the same error (only the restart write). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. CI build on macOS failed, but I consider this a library issue and not a problem with modified code in this PR.
This pull request brings in a new idealized channel setup that is been actively used in the KeyCLIM project. The channel setup is self-contained (needs no input) and easily modified by the user (bottom topography, initial stratification, and wind forcing are all controlled by namelist parameters). One can also easily modify the setup to include more complex forcing or idealized conditions.