-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Llt 5309 integrate multicast components #661
Conversation
0f9ce6e
to
1b8d6f8
Compare
As a reviewer I can't effectively review because while the PR description tells what this PR does(I understand words), it doesn't add any context, thus |
e5a69ab
to
b8373de
Compare
In a nutshell, starcast (*cast was the working name to cover multicast and broadcast as one word, and it could be pronounced as starcast if you say it as an actual word) is the meshnet implementation of multicast. I guess this is a general problem with "integration PRs" where you need to understand the components that are being integrated to properly understand and review the integration work. For more background you can check RFCs LLT-0060 and LLT-0047, or if it makes more sense, this could be a candidate for a review meeting or something like that to make it easier for you and to share some knowledge |
e3747ab
to
cc44505
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nit's
+1 |
d2a78aa
to
257f9f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.0
257f9f5
to
5a3b037
Compare
cd4a428
to
411bafd
Compare
411bafd
to
a5c91ff
Compare
Problem
All the separate parts of starcast (see RFC LLT-0060) are ready to be integrated into Telio.
Solution
This PR integrates all the separate starcast parts (virtual peer, transport and nat) into libtelio.
You can see the doc rs in code of every separate component to understand how they're supposed to be integrated into telio.
The Nat-Lab test for multicast is being implemented with a separate PR, so this one is untested yet.
☑️ Definition of Done checklist