Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove peripheral after disconnect #102

Merged

Conversation

everlof
Copy link
Contributor

@everlof everlof commented Nov 8, 2023

If we don't remove the peripheral, it will be reused (containing the services currently present). This is not how CBPeripheral works, there will be no services present after a disconnect -> connect.

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

@everlof
Copy link
Contributor Author

everlof commented Nov 9, 2023

Don't know how to get the CLA fixed. I've signed it and added the email I used to my account. I've also tried to trigger a "recheck"...

@philips77
Copy link
Member

You need to set up your git to use your e-mail address.

Your Identity
The first thing you should do when you install Git is to set your user name and email address. This is important because
every Git commit uses this information, and it’s immutably baked into the commits you start creating:

$ git config --global user.name "John Doe"
$ git config --global user.email johndoe@example.com

Then amend your last commit and force push it again to this branch. If you signed the CLA with that e-mail, it will work.

@everlof everlof force-pushed the remove-peripheral-on-disconnect branch from 046ea56 to 94af7a1 Compare November 9, 2023 11:50
@everlof
Copy link
Contributor Author

everlof commented Nov 9, 2023

You need to set up your git to use your e-mail address.

Your Identity
The first thing you should do when you install Git is to set your user name and email address. This is important because
every Git commit uses this information, and it’s immutably baked into the commits you start creating:

$ git config --global user.name "John Doe"
$ git config --global user.email johndoe@example.com

Then amend your last commit and force push it again to this branch. If you signed the CLA with that e-mail, it will work.

Great, thanks! That worked out perfect.

@philips77 philips77 self-assigned this Nov 9, 2023
Copy link
Member

@philips77 philips77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR. I finally have time to merge it and release the library.

@philips77 philips77 merged commit df76c6a into NordicSemiconductor:main Feb 19, 2024
1 check passed
@everlof everlof deleted the remove-peripheral-on-disconnect branch February 19, 2024 09:49
@everlof
Copy link
Contributor Author

everlof commented Feb 19, 2024

Great 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants