wrap CBPeripherals as CBMPeripheralNative on restore #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraps the CBPeripherals in the restored state as CBMPeripheralNative before sending the state to the delegate to allow it to be more consistent and compatible with code that expects CBMPeripheral.
|
|
|
Hello, |
Hi, I see it's already merged now, it's not a huge change. But yes I've tested it and I am using it currently. It does solve my issue in the sense that I now get objects that are more easily compatible with the rest of the library. |
|
Splendid! I will do a new release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found when trying to restore state that it was tricky as the state contains
CBPeripheralobjects, but the rest of the code more or less relies onCBMPeripheraleverywhere. One option would be to make theCBPeripheralNative.initpublic, but I think manipulating the state is more consistent with the CoreBluetoothMock API in general.