Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect notification status .isNotifying back ... #74

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

kscheff
Copy link
Contributor

@kscheff kscheff commented Aug 5, 2022

Reflect notification status .isNotifying back and make delegate didUpdateNotificationStateFor for mock implementation available.

When enabling a notification and sending data via .simulateValueUpdate the data is getting lost until the manager caught up with the enabling. Since the enabling is sent async with a delay to an internal queue it takes an uncertain time until data will be sent. The characteristics property .isNotifying is not updated in mock device implementation.

This fix implements a mock delegation didUpdateNotoficationStateFor: and updates .isNotifying property.

…dateNotificationStateFor for mock implementation available
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ philips77
❌ Kai Scheffer


Kai Scheffer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@NickKibish NickKibish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great. Just add a comment for the method, as I asked below.

@NickKibish
Copy link
Contributor

I see that #70 brings the same changes. So I close this PR.

@NickKibish NickKibish closed this Dec 16, 2022
@philips77 philips77 reopened this Feb 15, 2023
@philips77 philips77 merged commit a255d9b into NordicSemiconductor:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants