This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Feature/convert to py3 #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is work in progress
There is a rather arbitrary decision make in this change that PEMs are represented in bytes. It was selected in the interest of keeping conversions to a minimum. Both bytes and str are good candidated for representing PEM, which consists only of ascii chars.
Python's types.NoneType is no longer available, and it was not used anyway.
The test will still not complete due to changes in interal apis.
The new pc_ble_driver_py module with py3 support is SDv5 based.
The alternative is to instead .decode('ascii') the result from get_sk,
but since everyting is ascii, bytes is a suitable (as intended) type
that can actually be safer in case PEM files cannot contain non-ascii
values.
struct.pack in Python 3 returns bytes which gives ints when iterated over.
This way, importing nordicsemi works without changes to PYTHONPATH.
bihanssen
previously approved these changes
Sep 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.