This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Remove dependency version constraints #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove most dependency version constraints from requirements.txt, which is read by setup.py. This was done so that any project that depends on this one can choose dependency versions as freely as possible and is reposible for testing and freezing for its releases. This change also introduces a requirements-freeze.txt which freezes the dependency environment to a known good state for nrfutil that will be used for builds of nrfutil standalone executable. Sadly this means that installing nrfutil manually trough pip can break without warning. A possible solution for this is to create a dedicated package for nrfutil with the frozen dependencies. This would be ment to be run in a isolated environment using pipx or a simmilar tool.
bihanssen
reviewed
Oct 9, 2019
bihanssen
previously approved these changes
Oct 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove most dependency version constraints from requirements.txt, which
is read by setup.py. This was done so that any project that depends on
this one can choose dependency versions as freely as possible and is
reposible for testing and freezing for its releases. This change also
introduces a requirements-freeze.txt which freezes the dependency
environment to a known good state for nrfutil that will be used for
builds of nrfutil standalone executable.
Sadly this means that installing nrfutil manually trough pip can break
without warning. A possible solution for this is to create a dedicated
package for nrfutil with the frozen dependencies. This would be meant to
be run in an isolated environment using pipx or a simmilar tool.