Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Fix a bug where the softdevice requirement would not properly land in… #349

Closed
wants to merge 1 commit into from

Conversation

Yatekii
Copy link

@Yatekii Yatekii commented Mar 29, 2021

… the package if used from code and not CLI

… the package if used from code and not CLI
@CLAassistant
Copy link

CLAassistant commented Mar 29, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Noah Hüsser seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jornbh
Copy link
Contributor

jornbh commented Jul 4, 2022

This change looks good. But it is not up to date with the current master. Also, you will have to sign the Contributor License Agreement before this can be merged.

@Yatekii
Copy link
Author

Yatekii commented Jul 4, 2022

I don't use the CLI anymore and I already signed the CLA no matter what the Bot is trying to convey with its message.

Feel free to patch this in yourself - I do not claim any proprietorship to this change.

@jornbh jornbh mentioned this pull request Jul 5, 2022
@jornbh
Copy link
Contributor

jornbh commented Jul 5, 2022

Ok, thanks a lot for the help. I will close this PR, since I opened PR 381, since it is the same changes, documenting this conversation, and officially being "done by me".

@jornbh jornbh closed this Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants