Move SSL support to own library #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables us to put the SSL code in a separate library, like its done in hiredis. A user will be able to link to the new library when SSL is wanted, and there is no longer the need of having `SSL_SUPPORT` defined.
The tagged versions of hiredis does not include a required packaging correction. This correction is needed to be able to import hiredis CMake package.
A new target and package is created in CMake to build the library `hiredis_cluster_ssl`
Use the new `hiredis_library_ssl` when linking the test binaries, but only when building with SSL/TLS enabled. Since CMake supports transitive dependencies the `hiredis_cluster` library will make sure `hiredis` is include when linking, thus removing the explicit linkage in CMake.
Includes some cleanups and the use of CMAKE_PREFIX_PATH to remove some CMake configs.
zuiderkwast
reviewed
Apr 5, 2022
Add the missing hiredis targets if needed. This was corrected in hiredis via: redis/hiredis#1005 Revert changes for using newer hiredis in build and examples.
zuiderkwast
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the SSL support functionality to its own library, which a user can link to only when SSL support is wanted.
This follows how hiredis is structured with its
libhiredis.a/soandlibhiredis_ssl.a/so.Previously hiredis_cluster required users to build the library with or without SSL support, and were required to provide the
SSL_SUPPORTdefine to enable the SSL configuration API when building its project.Just linking to the new library instead is hopefully easier.
This also includes some CMake fixups by enabling transitive dependencies on targets.