Add support for Log4j2 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Logger.log4j.setLevel(org.apache.log4j.Level.toLevel(level)); | ||
| LoggerContext ctx = (LoggerContext) LogManager.getContext(false); | ||
| LoggerConfig loggerConfig = ctx.getConfiguration().getLoggerConfig(Logger.juli.getName()); | ||
| loggerConfig.setLevel(org.apache.logging.log4j.Level.OFF); |
There was a problem hiding this comment.
Should it not set level instead of always using Level#OFF?
|
Looks good, left one comment |
| PropertyConfigurator.configure(shutUp); | ||
| LoggerContext ctx = (LoggerContext) LogManager.getContext(false); | ||
| LoggerConfig loggerConfig = ctx.getConfiguration().getRootLogger(); | ||
| loggerConfig.setLevel(org.apache.logging.log4j.Level.OFF); |
There was a problem hiding this comment.
what does this line do?
Sets the default and lets the configuration define the each particular level?
There was a problem hiding this comment.
If not logging configuration is defined. It turns it off entirely.
|
looks good to me too (haven't tested it though) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.