Fix building error in expo project #1249

Kudo · 2022-01-21T13:02:55Z

Why

in expo sdk 44+ project, we opened formal swift integration. for swift to call objective-c functions, sometimes the #import format should be done right. learn more from expo/expo#15622 (comment)

fix #1237
fix expo/expo#15986

How

watermelonDB has a call from DatabaseBridge.swift to JSIInstaller.h. for swift to call objective-c functions, we should make JSIInstaller.h as a clang module. this pr moves JSIInstaller.h as cocoapods public header and the generated umbrella header will include JSIInstaller.h as a clang submodule.

Test Plan

expo sdk 44 project

expo init sdk44 # select bare
yarn add @nozbe/watermelondb
patch watermelondb with the pr changes
add these to ios/Podfile

  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi', :modular_headers => true
  pod 'simdjson', path: '../node_modules/@nozbe/simdjson'

npx pod-install
yarn ios

react-native 0.66 project

npx react-native init RN066 --version 0.66
yarn add @nozbe/watermelondb
patch watermelondb with the pr changes
add these to ios/Podfile

  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi', :modular_headers => true
  pod 'simdjson', path: '../node_modules/@nozbe/simdjson'

npx pod-install
yarn ios

enahum · 2022-02-26T23:01:28Z

@radex thoughts on having this merged ?

aircliff01 · 2022-03-13T20:43:52Z

Hey All, any reason this PR hasnt been merged? WatermelonDB is broken and pretty unusable on expo 44. This PR fixes the issue.

thecoorum · 2022-03-20T09:38:46Z

@Kudo does this work for expo projects with dev-client and expo prebuild -p ios? After following instructions it's failing on EAS Fastlane step with:

Compiling @nozbe/watermelondb Pods/WatermelonDB » Database.swift

❌  (node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/DatabaseBridge.swift:93:13)

  91 |         methodQueue.sync {
  92 |             // swiftlint:disable all
> 93 |             installWatermelonJSI(bridge as? RCTCxxBridge)
     |             ^ cannot find 'installWatermelonJSI' in scope
  94 |         }
  95 |         return [:]
  96 |     }

❌  (node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/DatabaseBridge.swift:103:9)

  101 |                          resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) {
  102 |         var error: NSError?
> 103 |         watermelondbProvideSyncJson(id.int32Value, json.data(using: String.Encoding.utf8.rawValue), &error)
      |         ^ cannot find 'watermelondbProvideSyncJson' in scope
  104 |         if let error = error {
  105 |             sendReject(reject, error)
  106 |         } else {

⚠️  (../../Library/Developer/Xcode/DerivedData/track-ezmllxjvzftvvzcdtnxcfnrldxbo/Build/Intermediates.noindex/ArchiveIntermediates/track/IntermediateBuildFilesPath/Pods.build/Debug-iphoneos/WatermelonDB.build/Objects-normal/arm64/Database-f1a153e176371a1f77b80228b6a743e6.dia:1:1)

> 1 | 
    | ^ Could not read serialized diagnostics file: error(in target 'WatermelonDB' from project 'Pods')
› Compiling @nozbe/watermelondb Pods/WatermelonDB » DatabaseBridge.swift

❌  (node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/DatabaseBridge.swift:93:13)

  91 |         methodQueue.sync {
  92 |             // swiftlint:disable all
> 93 |             installWatermelonJSI(bridge as? RCTCxxBridge)
     |             ^ cannot find 'installWatermelonJSI' in scope
  94 |         }
  95 |         return [:]
  96 |     }

❌  (node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/DatabaseBridge.swift:103:9)

  101 |                          resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) {
  102 |         var error: NSError?
> 103 |         watermelondbProvideSyncJson(id.int32Value, json.data(using: String.Encoding.utf8.rawValue), &error)
      |         ^ cannot find 'watermelondbProvideSyncJson' in scope
  104 |         if let error = error {
  105 |             sendReject(reject, error)
  106 |         } else {

and

The following build commands failed:
▸ 	CompileSwift normal arm64 /Users/expo/workingdir/build/node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/Database.swift (in target 'WatermelonDB' from project 'Pods')
▸ 	CompileSwift normal arm64 /Users/expo/workingdir/build/node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/DatabaseBridge.swift (in target 'WatermelonDB' from project 'Pods')
▸ 	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler (in target 'WatermelonDB' from project 'Pods')
▸ 	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler (in target 'expo-dev-menu' from project 'Pods')
▸ (4 failures)

Kudo · 2022-03-21T23:37:08Z

@thecoorum do you have some example repo? because the installation requires add extra pods to Podfile, i am assuming you would have a bare workflow app. otherwise, a config-plugin to add pods is required.
i've verified with this steps and it works for me.

expo init sdk44 # select bare
expo install expo-dev-client
yarn add @nozbe/watermelondb
patch watermelondb with the pr changes
add these to ios/Podfile

  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi', :modular_headers => true
  pod 'simdjson', path: '../node_modules/@nozbe/simdjson'

npx pod-install
yarn ios

KrisLau · 2022-04-19T18:14:04Z

@radex Waiting on this to be merged as migrating to expo Modules (specifically Expo 44) from unimodules breaks WatermelonDB

ruifernandees

I've tested and it is working good.

vtpa

Approved!

zsinryu · 2022-05-01T03:46:32Z

@vtpa @Kudo this have been approved.
Can you guys please merge this?

jwoo92 · 2022-05-01T18:30:14Z

I was able to get @nozbe/watermelondb@0.24.0 to work with Expo 44 after applying this patch.

Thank you 👍

KrisLau · 2022-05-05T14:21:24Z

@vtpa @Kudo this have been approved. Can you guys please merge this?

@zsinryu They cannot merge the pull request since I believe only @radex has that permission

zsinryu · 2022-05-05T16:46:52Z

@radex can you check this?

Hannes1 · 2022-05-05T20:24:51Z

Hey guys, can someone please post their patch package diff file, mine keeps failing when I generate it😭

jwoo92 · 2022-05-05T20:39:52Z

Hey guys, can someone please post their patch package diff file, mine keeps failing when I generate it😭

#1237 (comment)

Hannes1 · 2022-05-05T21:24:18Z

Hey guys, can someone please post their patch package diff file, mine keeps failing when I generate it😭

#1237 (comment)

Thanks @jwoo92 , I tried this already and keep getting a error when running npx patch, this is why I'm asking for the file someone already generated in their patch folder

jwoo92 · 2022-05-05T21:30:23Z

@Hannes1 Oh I missed that, here you go:

patches/@nozbe+watermelondb+0.24.0.patch

diff --git a/node_modules/@nozbe/watermelondb/WatermelonDB.podspec b/node_modules/@nozbe/watermelondb/WatermelonDB.podspec
index 1f3af50..e9fea58 100644
--- a/node_modules/@nozbe/watermelondb/WatermelonDB.podspec
+++ b/node_modules/@nozbe/watermelondb/WatermelonDB.podspec
@@ -13,7 +13,10 @@ Pod::Spec.new do |s|
   s.platforms    = { :ios => "9.0", :tvos => "9.0" }
   s.source = { :git => "https://github.com/Nozbe/WatermelonDB.git", :tag => "v#{s.version}" }
   s.source_files = "native/ios/**/*.{h,m,mm,swift,c,cpp}", "native/shared/**/*.{h,c,cpp}"
-  s.public_header_files = 'native/ios/WatermelonDB/SupportingFiles/Bridging.h'
+  s.public_header_files = [
+    'native/ios/WatermelonDB/SupportingFiles/Bridging.h',
+    'native/ios/WatermelonDB/JSIInstaller.h',
+  ]
   s.requires_arc = true
   # simdjson is annoyingly slow without compiler optimization, disable for debugging
   s.compiler_flags = '-Os'
diff --git a/node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/SupportingFiles/Bridging.h b/node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/SupportingFiles/Bridging.h
index 135118d..8324550 100644
--- a/node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/SupportingFiles/Bridging.h
+++ b/node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/SupportingFiles/Bridging.h
@@ -6,12 +6,6 @@
 
 #import <React/RCTBridgeModule.h>
 
-#if __has_include("JSIInstaller.h")
-#import "JSIInstaller.h"
-#else
-#import "../JSIInstaller.h"
-#endif
-
 #if __has_include("DatabaseDeleteHelper.h")
 #import "DatabaseDeleteHelper.h"
 #else

Hannes1 · 2022-05-05T21:33:04Z

@jwoo92 Greatly appreciated, thanks for the help🙏

diegoalvescf

Approved, I want this PR until tomorrow merged

jamesjlv

Approved!

zsinryu · 2022-05-22T10:10:19Z

@radex why this is not merged?

alexyoungs · 2022-06-13T19:22:05Z

Hey guys, checking in on whether this can be merged?

KrisLau · 2022-06-13T20:02:49Z

@alexyoungs Read the above thread. None of us have permission to do so, so it's currently just awaiting review/approval from @radex

ansh · 2022-09-04T03:18:31Z

Why is this PR not merged? It seems like it works.

Pining @radex and @RafalNozbe for help

itzzritik · 2022-09-26T09:59:29Z

@radex This PR needs to be merged, as WatermelonDB is no longer working for EXPO 44+
Looks like it's working for most people with this fix.

Can we merge it?

Dallas62 · 2022-12-19T22:18:51Z

Same fix but with:

  s.public_header_files = [
      'native/ios/WatermelonDB/**/*.h',
  ]

to build the library on 0.70.x and use_frameworks! :linkage => :static

ansh · 2022-12-20T08:01:06Z

@radex Some communication is the bare minimum after months of a valid PR from the Expo team.

radex · 2023-01-20T15:23:35Z

@Kudo Thank you

Dallas62 · 2023-01-21T20:03:38Z

Hi @radex, I still had to change the content of WatermelonDB.podspec with:

  s.public_header_files = [
      'native/ios/WatermelonDB/**/*.h',
  ]

And copy :

node_modules/@nozbe/simdjson/src/simdjson.h

In :

node_modules/@nozbe/watermelondb/native/shared

On 0.70.6

radex · 2023-01-23T08:02:12Z

@Dallas62 Can you please elaborate? What issues did you see, what changes did you have to make, which Expo version?

Dallas62 · 2023-01-23T08:24:07Z

This issue doesn't happen with Expo, it's mainly not resolve import in the native side (same file of this issue).

Will provide more details later

radex · 2023-01-23T14:27:28Z

@Dallas62 Please do provide more details. Are you using Turbo Sync by any chance?

KrisLau · 2023-01-23T14:31:34Z

@radex so the issue @Dallas62 was facing is probably related to use_frameworks! and I also have the same thing patched. It would be nice to be able to have it permanently fixed since react-native-firebase requires the use of use_frameworks! now.

Relevant thread: #1285
My changes: #1285 (comment)

Dallas62 · 2023-01-23T14:35:51Z

@KrisLau Exactly this case, all details are mentioned in this comment #1285 (comment)

Fix building error in expo project

86abdc2

brentvatne mentioned this pull request Jan 25, 2022

SDK44 breaks iOS build of @nozbe/watermelondb expo/expo#15986

Closed

Yarkhan mentioned this pull request Jan 25, 2022

cannot find installWatermelonJSI & watermelondbProvideSyncJson in scope #1237

Closed

Yarkhan mentioned this pull request Feb 11, 2022

Wasn't able to make it work with Expo v44 and EAS morrowdigital/watermelondb-expo-plugin#2

Closed

brunokiafuka mentioned this pull request Apr 14, 2022

Setting up the plugin morrowdigital/watermelondb-expo-plugin#3

Closed

ruifernandees approved these changes Apr 27, 2022

View reviewed changes

vtpa approved these changes Apr 27, 2022

View reviewed changes

This was referenced May 2, 2022

Expo Ejected -> Build Problem #1284

Open

Project doesn't compile after installing watermelondb with Expo #1292

Closed

KrisLau approved these changes May 5, 2022

View reviewed changes

MillingtonAllen mentioned this pull request May 10, 2022

TypeError: null is not an object (evaluating 'DatabaseBridge.initializeJSI') #1325

Closed

diegoalvescf approved these changes May 12, 2022

View reviewed changes

jamesjlv approved these changes May 12, 2022

View reviewed changes

KrisLau mentioned this pull request May 26, 2022

feat: support sortBy on joined table #1327

Open

KrisLau mentioned this pull request Sep 8, 2022

[Question] More details on offline first? #1351

Closed

KrisLau mentioned this pull request Sep 26, 2022

Please Merge PR #1249 #1396

Closed

KrisLau mentioned this pull request Oct 4, 2022

Waterlemon db auto sync on native side react-native #1372

Open

This was referenced Jan 13, 2023

NativeModules.DatabaseBridge is not defined #1408

Closed

Compilation error for RN 0.71 #1469

Closed

radex merged commit 78d9562 into Nozbe:master Jan 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix building error in expo project #1249

Fix building error in expo project #1249

Kudo commented Jan 21, 2022

enahum commented Feb 26, 2022

aircliff01 commented Mar 13, 2022

thecoorum commented Mar 20, 2022

Kudo commented Mar 21, 2022

KrisLau commented Apr 19, 2022 •

edited

Loading

ruifernandees left a comment

vtpa left a comment

zsinryu commented May 1, 2022

jwoo92 commented May 1, 2022

KrisLau commented May 5, 2022

zsinryu commented May 5, 2022

Hannes1 commented May 5, 2022

jwoo92 commented May 5, 2022

Hannes1 commented May 5, 2022 •

edited

Loading

jwoo92 commented May 5, 2022

Hannes1 commented May 5, 2022

diegoalvescf left a comment

jamesjlv left a comment

zsinryu commented May 22, 2022

alexyoungs commented Jun 13, 2022

KrisLau commented Jun 13, 2022

ansh commented Sep 4, 2022

itzzritik commented Sep 26, 2022

Dallas62 commented Dec 19, 2022

ansh commented Dec 20, 2022

radex commented Jan 20, 2023

Dallas62 commented Jan 21, 2023

radex commented Jan 23, 2023

Dallas62 commented Jan 23, 2023

radex commented Jan 23, 2023

KrisLau commented Jan 23, 2023 •

edited

Loading

Dallas62 commented Jan 23, 2023

Fix building error in expo project #1249

Fix building error in expo project #1249

Conversation

Kudo commented Jan 21, 2022

Why

How

Test Plan

expo sdk 44 project

react-native 0.66 project

enahum commented Feb 26, 2022

aircliff01 commented Mar 13, 2022

thecoorum commented Mar 20, 2022

Kudo commented Mar 21, 2022

KrisLau commented Apr 19, 2022 • edited Loading

ruifernandees left a comment

Choose a reason for hiding this comment

vtpa left a comment

Choose a reason for hiding this comment

zsinryu commented May 1, 2022

jwoo92 commented May 1, 2022

KrisLau commented May 5, 2022

zsinryu commented May 5, 2022

Hannes1 commented May 5, 2022

jwoo92 commented May 5, 2022

Hannes1 commented May 5, 2022 • edited Loading

jwoo92 commented May 5, 2022

Hannes1 commented May 5, 2022

diegoalvescf left a comment

Choose a reason for hiding this comment

jamesjlv left a comment

Choose a reason for hiding this comment

zsinryu commented May 22, 2022

alexyoungs commented Jun 13, 2022

KrisLau commented Jun 13, 2022

ansh commented Sep 4, 2022

itzzritik commented Sep 26, 2022

Dallas62 commented Dec 19, 2022

ansh commented Dec 20, 2022

radex commented Jan 20, 2023

Dallas62 commented Jan 21, 2023

radex commented Jan 23, 2023

Dallas62 commented Jan 23, 2023

radex commented Jan 23, 2023

KrisLau commented Jan 23, 2023 • edited Loading

Dallas62 commented Jan 23, 2023

KrisLau commented Apr 19, 2022 •

edited

Loading

Hannes1 commented May 5, 2022 •

edited

Loading

KrisLau commented Jan 23, 2023 •

edited

Loading