Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Require package source mapping when using CPM #11505

Closed
jeffkl opened this issue Jan 12, 2022 · 5 comments · Fixed by NuGet/NuGet.Client#4505
Closed

[Feature]: Require package source mapping when using CPM #11505

jeffkl opened this issue Jan 12, 2022 · 5 comments · Fixed by NuGet/NuGet.Client#4505
Assignees
Labels
Area:RestoreCPM Central package management Functionality:Restore Priority:2 Issues for the current backlog. Type:Feature

Comments

@jeffkl
Copy link
Contributor

jeffkl commented Jan 12, 2022

NuGet Product(s) Involved

NuGet.exe, Visual Studio Package Management UI, Visual Studio Package Manager Console, MSBuild.exe, dotnet.exe

The Elevator Pitch

To make NuGet secure by default, there should be an option to required package source mapping when using more than one feed and central package management.

Additional Context and Details

No response

@jeffkl jeffkl added Priority:2 Issues for the current backlog. Type:Feature Functionality:Restore Area:RestoreCPM Central package management Pipeline:Backlog labels Jan 12, 2022
@jeffkl jeffkl self-assigned this Jan 12, 2022
@aortiz-msft aortiz-msft changed the title [Feature]: Add option to require package source mapping when using CPM [Feature]: Require package source mapping when using CPM Jan 31, 2022
@tebeco
Copy link

tebeco commented Feb 7, 2022

Will this be MsBuild first so that one could finnaly get rid of nuget.config ?

@jeffkl jeffkl added this to the Sprint 2022-03 milestone Feb 28, 2022
@jeffkl
Copy link
Contributor Author

jeffkl commented Mar 7, 2022

Will this be MsBuild first so that one could finnaly get rid of nuget.config ?

@tebeco package source mapping currently only works when defined in NuGet.config. The feature described in this issue is to simply require package source mapping when managing package versions centrally.

@tebeco
Copy link

tebeco commented Mar 7, 2022

yes my question still stands though.

it's really like to avoid relying on a non flexible xml and to msbuild for most of what's possible

feed list
dotnet tool
source mapping

i don't understand the need of nuget.config being a non standard format (i mean not msbuild compliant). We're recreating the same problem as SLN file but this time it's named nuget.config

@jeffkl
Copy link
Contributor Author

jeffkl commented Mar 7, 2022

@tebeco I would recommend you open a new feature request to allow package source mapping definitions to come from MSBuild instead of NuGet.config. Keep in mind there are certain technical limitations when it comes to where configuration data is stored (example #7855). I'm not sure if package source mapping would suffer from any of these limitations.

@jimmylewis
Copy link

I'm curious why CPVM plays into this at all. Shouldn't this warning also be shown if not using CPVM? How does CPVM change the threat model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:RestoreCPM Central package management Functionality:Restore Priority:2 Issues for the current backlog. Type:Feature
Projects
None yet
3 participants