Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCR]: Print sources in NU1507 #11715

Closed
jeffkl opened this issue Apr 4, 2022 · 1 comment · Fixed by NuGet/NuGet.Client#4609
Closed

[DCR]: Print sources in NU1507 #11715

jeffkl opened this issue Apr 4, 2022 · 1 comment · Fixed by NuGet/NuGet.Client#4609
Assignees
@jeffkl
Labels
Area:RestoreCPM Central package management Functionality:Restore Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Milestone
6.3

Comments

@jeffkl
Copy link
Contributor

jeffkl commented Apr 4, 2022

NuGet Product(s) Affected

NuGet.exe, MSBuild.exe, dotnet.exe

Current Behavior

As part of #11505, we emit a warning that only displays the number of sources in use.

Desired Behavior

We should just print the sources themselves in the warning because the sources can come from lots of places and at the moment its hard to determine what sources are in use and from where.

Additional Context

No response
@jeffkl jeffkl added Type:DCR Design Change Request Triage:Untriaged labels Apr 4, 2022
@jeffkl jeffkl mentioned this issue Apr 4, 2022
Merged
8 tasks
@jeffkl jeffkl added Functionality:Restore Pipeline:Backlog Priority:2 Issues for the current backlog. Area:RestoreCPM Central package management and removed Triage:Untriaged labels Apr 4, 2022
@nkolev92
Copy link
Member

Hey folks, for issues that obvious bugs and that are known as something that needs to be done, or being actively worked on, to fully self triage:

https://github.com/NuGet/Client.Engineering/blob/main/docs/creating-github-issues.md

@jeffkl jeffkl mentioned this issue Apr 15, 2022
Closed
7 tasks
@jeffkl jeffkl added this to the Sprint 2022-05 milestone May 2, 2022
@jeffkl jeffkl self-assigned this May 2, 2022
jeffkl added a commit to NuGet/NuGet.Client that referenced this issue May 3, 2022
@jeffkl
Add sources to NU1507 warning
bdbf614 
Fixes NuGet/Home#11715
@jeffkl jeffkl mentioned this issue May 3, 2022
Merged
8 tasks
@nkolev92 nkolev92 removed this from the Sprint 2022-05 milestone May 3, 2022
@heng-liu heng-liu added this to the 6.3 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffkl jeffkl

Labels
Area:RestoreCPM Central package management Functionality:Restore Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Projects
None yet
Milestone
6.3
Development

Successfully merging a pull request may close this issue.

Add sources to NU1507 warning NuGet/NuGet.Client
3 participants
@nkolev92 @jeffkl @heng-liu