Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better restore handling of deleted feed packages #5012

Closed
emgarten opened this issue Apr 11, 2017 · 0 comments
Closed

Better restore handling of deleted feed packages #5012

emgarten opened this issue Apr 11, 2017 · 0 comments
Assignees
@emgarten
Milestone
4.3 - 3/27 thru 4/14

Comments

@emgarten
Copy link
Member

Scenario

  1. Restore downloads the index.json file from packagebaseaddress and it contains version 1.0.0, 2.0.0, 3.0.0
  2. The feed prunes version 1.0.0
  3. Later restore loads the cached index.json file and attempts to download version 1.0.0
  4. The download fails because the package was not found.

When investigating a recent asp.net build issue it looked like this was leading to errors that could be avoided by reloading the feed index, or by trying the next version in the list.

Either way this scenario should be covered in tests and checked to ensure it is a good user experience since most feed providers allow deleting packages.
@emgarten emgarten added this to the 4.3 - 3/27 thru 4/14 milestone Apr 14, 2017
@emgarten emgarten self-assigned this Apr 14, 2017
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Apr 14, 2017
@emgarten
Invalidate http cache when a package has been deleted from a feed
763dcbb 
This change adds support for invalidating the http cache on a per package id basis when a 404 is received. As part of that finding the original casing of the package has been moved into the GetDependency request where the package is downloaded to disk.

Perf improvements along with this:
* Packages are downloaded only if they are the best match, previously this was done a per feed basis which caused unneeded downloads
* Added additional caching for nuspecs and dependency info

Fixes NuGet/Home#5023
Fixes NuGet/Home#5012
@emgarten emgarten mentioned this issue Apr 14, 2017
Merged
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Apr 18, 2017
@emgarten
Invalidate http cache when a package has been deleted from a feed
26e8bc0 
This change adds support for invalidating the http cache on a per package id basis when a 404 is received. As part of that finding the original casing of the package has been moved into the GetDependency request where the package is downloaded to disk.

Perf improvements along with this:
* Packages are downloaded only if they are the best match, previously this was done a per feed basis which caused unneeded downloads
* Added additional caching for nuspecs and dependency info

Fixes NuGet/Home#5023
Fixes NuGet/Home#5012

Addressing feedback
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Apr 18, 2017
@emgarten
Invalidate http cache when a package has been deleted from a feed
527488e 
This change adds support for invalidating the http cache on a per package id basis when a 404 is received. As part of that finding the original casing of the package has been moved into the GetDependency request where the package is downloaded to disk.

Perf improvements along with this:
* Packages are downloaded only if they are the best match, previously this was done a per feed basis which caused unneeded downloads
* Added additional caching for nuspecs and dependency info

Fixes NuGet/Home#5023
Fixes NuGet/Home#5012

Addressing feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emgarten emgarten

Labels
None yet
Projects
None yet
Milestone
4.3 - 3/27 thru 4/14
Development

No branches or pull requests
1 participant
@emgarten