Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken test in TimestampTests #8935

Closed
heng-liu opened this issue Dec 13, 2019 · 4 comments
Closed

Broken test in TimestampTests #8935

heng-liu opened this issue Dec 13, 2019 · 4 comments
Assignees
Labels
Functionality:Signing Priority:2 Issues for the current backlog.

Comments

@heng-liu
Copy link
Contributor

In TimestampTests,
test Timestamp_Verify_WithOfflineRevocation_ReturnsCorrectFlagsAndLogsAsync failed on Linux and Mac.

@heng-liu heng-liu self-assigned this Jan 21, 2020
@heng-liu heng-liu added this to the Sprint 165 milestone Jan 21, 2020
@heng-liu heng-liu removed this from the Sprint 165 milestone Jan 21, 2020
@heng-liu heng-liu removed their assignment Jan 28, 2020
@zkat zkat self-assigned this Jan 29, 2020
@zkat zkat added this to the Sprint 165 - 2020.01.20 milestone Jan 29, 2020
@zkat
Copy link
Contributor

zkat commented Jan 29, 2020

Note: This is hanging when calling SignedArchiveTestUtility.CreateAuthorSignatureForPackageAsync, so the failure might just be a bug in our test utility. Looking into it now.

@heng-liu
Copy link
Contributor Author

Pls take this into consideration for Mac.

@zkat zkat removed the Type:Test label Feb 3, 2020
zkat added a commit to NuGet/NuGet.Client that referenced this issue Feb 5, 2020
zkat added a commit to NuGet/NuGet.Client that referenced this issue Feb 14, 2020
@rrelyea
Copy link
Contributor

rrelyea commented Feb 21, 2020

is this ready for review? think that the current PR had failures still. i checked because it is in the "in review" column on the board.

@zkat
Copy link
Contributor

zkat commented Feb 21, 2020

Sorry, I should've moved it back to In Progress.

@zkat zkat added the Priority:2 Issues for the current backlog. label Feb 25, 2020
@zkat zkat removed this from the Sprint 166 - 2020.02.10 milestone Mar 2, 2020
@zkat zkat assigned zkat and unassigned zkat Mar 2, 2020
@zkat zkat added this to the Sprint 167 - 2020.03.02 milestone Mar 2, 2020
@zkat zkat removed their assignment Mar 2, 2020
@zkat zkat removed this from the Sprint 167 - 2020.03.02 milestone Mar 2, 2020
@zkat zkat self-assigned this Mar 2, 2020
@zkat zkat modified the milestone: Sprint 167 - 2020.03.02 Mar 4, 2020
@zkat zkat added this to the Sprint 170 - 2020.05.04 milestone May 4, 2020
zkat added a commit to NuGet/NuGet.Client that referenced this issue Jun 15, 2020
heng-liu pushed a commit to NuGet/NuGet.Client that referenced this issue Jun 17, 2020
heng-liu pushed a commit to NuGet/NuGet.Client that referenced this issue Jun 18, 2020
* get TimestampTests working again

Fixes: NuGet/Home#8935
heng-liu pushed a commit to NuGet/NuGet.Client that referenced this issue Jun 19, 2020
* get TimestampTests working again

Fixes: NuGet/Home#8935
heng-liu pushed a commit to NuGet/NuGet.Client that referenced this issue Jun 19, 2020
* get TimestampTests working again

Fixes: NuGet/Home#8935
pombredanne pushed a commit to aboutcode-org/univers that referenced this issue Apr 1, 2022
* Signing: Support signature verification on .NET Core

Remove 2nd N.B.T.P package (#2984)

remove WorkaroundNetStandard target, change SDK for build from 3.0 preview to 3.1 stable (#3161)

* remove WorkaroundNetStandard target, change SDK for build from 3.0 preview to 3.1 stable version, fix error; change LockSDKVersion default value from empty string to false; apply Linux workaround in my change

Retarget to netcore5.0 (#3162)

* retarget to netcore5.0;  Linux script workaround need to apply for downloading SDK for build

add pkcs and cng packages

Temporary fix on patching SDK, add System.Security.Cryptography.Pkcs.dll and update deps.json, use dll from .nuget/packages

Address PR comments

implement add cert to store on Mac; display openssl version (#3166)

Implement timestamp integrity verification; Implement an equivalent NativeCms; enable signing APIs and tests (#3168)

* implement timestamp integrity verification; implement ManagedCms; enable signing APIs and tests

fix xplat verification branch after rebase (#3191)

Fixes: NuGet/Home#9012

check different cross-platform error messages for self-signed cert test (#3208)

Fixes: NuGet/Home#8933

Xplat Signing/Verification : Fix broken tests for setting privatekey of a X509Certificate2 (#3195)

use workaround to set private key for X509Certificate2 (netcore), change ToRSA to workaround for netcore(especially for non-windows)

enable PathTooLongException test (#3216)

Fixes: NuGet/Home#8920

enable TrustedSignerActionsProvider on netcore, along with tests (#3213)

Fixes: NuGet/Home#8921

Enable SignedPackageIntegrityVerificationTests for netcore5.0 (#3220)

Enable SignedPackageIntegrityVerificationTests for netcore, remove extra preprocessors

Enable timestamp provider test and fix 3 broken tests (#3210)

enable all unit tests; enable 8 more tests; enable timestampProviderTest; fix 3 broken tests in TimestampProviderTests

Fix 4 tests in SignatureTrustAndValidityVerificationProviderTests (#3242)

fix untrusted msg for different platforms

fixed broken tests using utility methods (#3263)

disable outdated tests (#3274)

enable 4 tests on Mac (#3275)

fix 5 broken tests in SignatureTrustAndValidityVerificationProviderTests, add workaround for Linux (#3252)

fix broken test case ExecuteCommandAsync_WithAmbiguousMatch_ThrowsAsync (#3291)

* Enable test ExecuteCommandAsync_WithMultiplePackagesAndInvalidCertificate_RaisesErrorsOnceAsync (#3342)

* enable a test, change the comments; extend test limitation on Linux

* Updated SDK version and removed the hardcoded version when reading from JSON file (#3372)

* update Pkcs package to the preview3 version (#3382)

* fix 2 warnings in CodeAnalysis (#3388)

* fix 2 warnings in CodeAnalysis

* disable dynamic revoke tests on Mac (#3373)

* fix 1 test (#3371)

* Fix more warnings reported by CodeAnalysis (#3393)

* fix string warnings raised by CodeAnalysis

* Retarget xplat verification to netcoreapp5.0 (#3386)

* retarget netcoreapp5.0 (a workaround for net5.0)

* fix all the rest warnings raised by code analysis (#3401)

* Suppress CA1307 warning for string.GetHashCode() method (#3404)

* Linux test failure due to generic exception (#3405)

* add TFM netcoreapp5.0 to N.B.T.Console and N.P.Core projects (#3419)

* add TFM netcoreapp5.0 to N.B.T.Console and N.P.Core projects

* add PIN prompt for netcore (#3389)

* Run dotnet nuget tests on multiple TFMs (#3387)

* enabled mac assertions

* Revert "enabled mac assertions"

This reverts commit d8a52e20c204720f106eaf116d1895f68b557d56.

* Enable test GetCertificateChain_WithUntrustedRoot_Throws on Mac (#3428)

* run signing integration tests cross plat (#3415)

* added GetNonce() to IRfc3161TimestampRequest interface (#3427)

* disable test for netcore (#3445)

* log Status and StatusInformation, fix 2 tests (#3268)

* Disable verification during extraction for Mono, disable a test on Mono (#3451)

* disable verification during extraction on mono,disable a mono test on Mac

* adapt 2 newly added dotnet integration tests for multiple TFMs (#3460)

* remove useless Sdk2x.targets

* get TimestampTests working again (#3218)

* get TimestampTests working again

Fixes: NuGet/Home#8935

* change GetTimestampAsync into internal

* fix runFuncTests.sh and InstallCLIforBuild.sh

* address feedback

* upgrade dotnet 5 to preview4 as preview5 is broken

* Fix exception thrown in SigningTestFixture during disposing (#3464)

Co-authored-by: Kartheek Penagamuri <52756182+kartheekp-ms@users.noreply.github.com>
Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com>
Co-authored-by: Kat Marchán <kzm@zkat.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Signing Priority:2 Issues for the current backlog.
Projects
None yet
Development

No branches or pull requests

4 participants