Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet in VS Code/C# Dev Kit MVP Proposal #13208

Merged
merged 13 commits into from
Feb 15, 2024
Merged

NuGet in VS Code/C# Dev Kit MVP Proposal #13208

merged 13 commits into from
Feb 15, 2024

Conversation

albarry4
Copy link
Contributor

@albarry4 albarry4 commented Jan 30, 2024

This proposal introduces a Visual Studio Code NuGet package management experience including command palette flows and integration with C# Dev Kit. It covers the initial experiences for adding, removing, and updating a NuGet package. This document covers the minimum viable product (MVP) for a NuGet command palette experience, and leaves room for growth and expansion on these initial concepts, both in enhancing these 3 features, or in the addition of more NuGet command palette features.

Rendered Spec

Please 👍 or 👎 this comment to help us with the direction of this feature & leave as much feedback/questions/concerns as you'd like on this issue itself and we will get back to you shortly.

Thank You 🎉

Related: microsoft/vscode-dotnettools#62


Once a package is selected from the list, the user will then be prompted to select the version number that they would like to install.

![Alt text](../../meta/resources/vscode-commands/addpackage-versionselect.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this prefer the highest stable version? Imagine a user prefers to install stable versions but a package's 10 highest versions are all pre-release, this would be a frustrating experience.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great callout, yes this will depend on the settings a user provides similar to Visual Studio checking the include pre-release checkbox. It will prefer highest stable by default.

@albarry4 albarry4 requested a review from a team February 1, 2024 21:28
@JonDouglas JonDouglas requested a review from a team February 2, 2024 00:38
@Leonardo-Ferreira
Copy link

I don't know why you people keep focusing on the bloody command palette... if a developer is skilled enough to use the palette he's probably is comfortable enough to use the raw terminal.

Focus on the "I want to use my mouse and all I know is that the package has 'SqlServer' somewhere on its name" kind of developer... focus on the "I want to update all the packages on my solution and I don't care or know which is the latest version"...

@loic-sharma
Copy link
Contributor

loic-sharma commented Feb 3, 2024

@Leonardo-Ferreira Please review the .NET Foundation's code of conduct: https://dotnetfoundation.org/about/policies/code-of-conduct

In particular, the following behaviors are recommended to foster a positive environment:

  • Demonstrating empathy and kindness toward other people
  • Being respectful of differing opinions, viewpoints, and experiences

@JonDouglas
Copy link
Contributor

JonDouglas commented Feb 4, 2024

I don't know why you people keep focusing on the bloody command palette... if a developer is skilled enough to use the palette he's probably is comfortable enough to use the raw terminal.

Focus on the "I want to use my mouse and all I know is that the package has 'SqlServer' somewhere on its name" kind of developer... focus on the "I want to update all the packages on my solution and I don't care or know which is the latest version"...

We understand your frustration @Leonardo-Ferreira. For the sake of time, we are moving forward with a command palette experience and will be working iteratively with developer feedback to build a robust and rich NuGet experience into Visual Studio Code. You can see the related issue to understand where we imagine our work can take us.

microsoft/vscode-dotnettools#62

We are building experiences for many different cohorts of C#/F#/etc/.NET developers. Please continue to provide your feedback on these experiences, but all we ask is that you choose words of mutual respect. Frustration is completely fine, but let the frustration be objective towards the proposal, not the people behind the proposal(ad hominem).

Copy link
Contributor

@JonDouglas JonDouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@albarry4
Copy link
Contributor Author

I think this is ready to merge!

@albarry4 albarry4 merged commit 99910e1 into dev Feb 15, 2024
1 check passed
@albarry4 albarry4 deleted the totally-not-interesting branch February 15, 2024 22:01
@evgenyvalavin
Copy link

I'm not sure where to link this
#13429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants