Disable verification during extraction for Mono, disable a test on Mo…

…no (#3451) * disable verification during extraction on mono,disable a mono test on Mac
NuGet · Jun 19, 2020 · 92999ab · 92999ab
1 parent 279296e
commit 92999ab
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/NuGet.Core/NuGet.Packaging/PackageArchiveReader.cs b/src/NuGet.Core/NuGet.Packaging/PackageArchiveReader.cs
@@ -381,7 +381,16 @@ public override Task<byte[]> GetArchiveHashAsync(HashAlgorithmName hashAlgorithm
         public override bool CanVerifySignedPackages(SignedPackageVerifierSettings verifierSettings)
         {
 #if IS_SIGNING_SUPPORTED
-            return true;
+            // Mono support has been deprioritized, so verification on Mono is not enabled, tracking issue: https://github.com/NuGet/Home/issues/9027
+            if (RuntimeEnvironmentHelper.IsMono)
+            {
+                return false;
+            }
+            else
+            {
+                return true;
+            }
+
 #else
             return false;
 #endif

diff --git a/test/NuGet.Clients.Tests/NuGet.CommandLine.Test/NuGetVerifyCommandTest.cs b/test/NuGet.Clients.Tests/NuGet.CommandLine.Test/NuGetVerifyCommandTest.cs
@@ -58,7 +58,7 @@ public void VerifyCommand_WrongInput_NotFound()
             }
         }
 
-        [Fact]
+        [PlatformFact(Platform.Windows, SkipMono = true)]
         public void VerifyCommand_WithAuthorSignedPackage_FailsGracefully()
         {
             var nugetExe = Util.GetNuGetExePath();
-Original file line number
+Diff line change
@@ Expand Up / @@ -58,7 +58,7 @@ public void VerifyCommand_WrongInput_NotFound() @@
                 }
             }
-            [Fact]
+            [PlatformFact(Platform.Windows, SkipMono = true)]
             public void VerifyCommand_WithAuthorSignedPackage_FailsGracefully()
             {
                 var nugetExe = Util.GetNuGetExePath();
@@ Expand Down @@