Retry http 429 responses #4897
Merged
Retry http 429 responses #4897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jeffkl
reviewed
Nov 7, 2022
nkolev92
previously approved these changes
Nov 8, 2022
nkolev92
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12214
Regression? No
Description
I looked though Wikipedia's list of HTTP status codes, and in addition to 429, it looks like 408 is theoretically worth trying as well. I've never seen a customer complain about it though, and I think that pushing a nupkg is the only scenario that might feasibly happen. 🤷
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation