Fix floating version functionality for FloatingBehavior.AbsoluteLatest in new dependency graph resolver #6070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
force-pushed
the
dev-jeffkl-dependency-resolver-floating-versions
branch
from
4704217
to
2964cf1
Compare
jeffkl
changed the title
jeffkl
force-pushed
the
dev-jeffkl-dependency-resolver-floating-versions
branch
from
f60415b
to
00e6f96
Compare
jeffkl
force-pushed
the
dev-jeffkl-dependency-resolver-floating-versions
branch
from
00e6f96
to
247f36b
Compare
nkolev92
approved these changes
Oct 3, 2024
jeffkl
added a commit
that referenced
this pull request
Oct 3, 2024
…t in new dependency graph resolver (#6070)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13830
Description
RemoteDependencyWalker.IsEqualToOrGreaterThan()is calculating whether or not a VersionRange is equal to or greater than another VersionRange incorrectly in the case of*or*-*. For ranges like1.*or1.0.*, it treats the star as "highest possible" by converting the version range to useInt.MaxValuefor the parts of the version that are floating. However, for something like*or*-*, it falls back to just using the specified values and it uses0.0.0.0instead which is always treated as lower. This makes the new dependency resolver pick the wrong versions or improperly detect downgrades.The change is to treat
*or*-*asInt.MaxValue.Int.MaxValue.Int.MaxValue.Int.MaxValue, essentially the highest possible version range.PR Checklist