-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Microsoft.VSSDK.BuildTools from 17.0.1600 to 17.12.2069 #6078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
c0de869
to
58d8e13
Compare
c5582e7
to
b9f3b53
Compare
b9f3b53
to
758a1b5
Compare
src/NuGet.Clients/NuGet.VisualStudio.Client/NuGet.VisualStudio.Client.csproj
Outdated
Show resolved
Hide resolved
a28ba09
to
0382cdd
Compare
0382cdd
to
bace686
Compare
@@ -272,6 +272,7 @@ | |||
<ItemGroup> | |||
<VsixIncludeFile Include=".vsixinclude" /> | |||
<VsixIgnoreFile Include=".vsixignore" /> | |||
<VsixIgnoreFile Include=".vsixignore.CI" Condition="'$(IsCIBuild)' == 'true'" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just like to confirm if someone downloaded the vsix from the dev branch, and from this branch, and validated that the files in both vsix's are the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the PR ready to be reviewed and merged, or is it still being worked on while the file differences are still being worked on?
When this PR pops up in my notification list, I'm not sure if I should review and approve, or if I should wait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ready for review. Sorry for the noise in the past day or so, we kept thinking it was done but little things kept cropping up. It appears my build is green which is why I'm updating the description now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a nifty table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this PR pops up in my notification list, I'm not sure if I should review and approve, or if I should wait.
Open to suggestions. Even if I had put it back to a draft, you'll still get those notifications as GitHub does not unsubscribe anyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but if I see a notification for a draft PR, I can immediately move on, knowing I'll get another notification when it's ready for review, at which time I should look at the diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Bug
Fixes: NuGet/Home#13832
Description
It seems we don't regularly update Microsoft.VSSDK.BuildTools and therefore we have a very old 17.0.x version of that dependency
NuGet.Client/Directory.Packages.props
Line 79 in db35f73
Microsoft.VSSDK.BuildTools
from 17.0.1600 to 17.12.2069Microsoft.VisualStudio.ExtensionEngineContract
Likely, there was some breaking change that's occurred between 17.0 and 17.12.
Side effects
Lucene.net
from a different directory via a Project Reference which was not signed, and therefore failed our signing verification. @jeffkl added a step to remove the unsigned version of this assembly when it's being pulled from a Project Reference.*resources.dll
assemblies items just before our build adds them as it has historically with theGetLocalizedDlls
Target that follows.VSIX content changes
NuGet.VisualStudio.Client.clientenabledpkg
since the CodeSpaces functionality for this was moved to GitHub Codespaces by 2022NuGet.PackageManagement.PowerShellCmdlets.dll-Help.xml
which is the only XML file we ship. It appears to be used for PowerShell Console help (eg, get-help install-package).Delta in our VSIX content with this PR:
Flattened directory content files used for comparison:
dev branch files.txt
this branch fe0f5e1ed files.txt
Special thanks to @jeffkl for helping address the above side effects with his MS Build expertise :)
PR Checklist