Update Microsoft.VSSDK.BuildTools from 17.0.1600 to 17.12.2069

[donnie-msft]

Bug

Fixes: NuGet/Home#13832

Description

It seems we don't regularly update Microsoft.VSSDK.BuildTools and therefore we have a very old 17.0.x version of that dependency

NuGet.Client/Directory.Packages.props

Line 79 in db35f73

<PackageVersion Include="Microsoft.VSSDK.BuildTools" Version="17.0.1600" />

• Update Microsoft.VSSDK.BuildTools from 17.0.1600 to 17.12.2069
  • Note that I did try some slightly older packages from 17.11.x, but experienced vulnerable transitive dependencies and decided the latest stable version was best to work towards.
• Add reference to the new Microsoft.VisualStudio.ExtensionEngineContract
• Add/Remove assemblies from the VSIX as necessary from the change to dependent assemblies

Likely, there was some breaking change that's occurred between 17.0 and 17.12.

Side effects

• The VSSDK was now finding Lucene.net from a different directory via a Project Reference which was not signed, and therefore failed our signing verification. @jeffkl added a step to remove the unsigned version of this assembly when it's being pulled from a Project Reference.
• The VSSDK was now adding all localization resource assemblies which it did not do previously. This caused the wrong root path to be used for localized assemblies. @jeffkl put in a removal of all of those *resources.dll assemblies items just before our build adds them as it has historically with the GetLocalizedDlls Target that follows.

VSIX content changes

• Our VSIX no longer includes a NuGet.VisualStudio.Client.clientenabledpkg since the CodeSpaces functionality for this was moved to GitHub Codespaces by 2022
• The VSSDK is now including generated XML Documentation files for assemblies. I've added this to the ignore list since we do not want to ship them. Our build logic now considers .XML file extensions when loading files for the vsixinclude/vsixignore comparison.
• Include in the VSIX the NuGet.PackageManagement.PowerShellCmdlets.dll-Help.xml which is the only XML file we ship. It appears to be used for PowerShell Console help (eg, get-help install-package).

Delta in our VSIX content with this PR:

Removed from VSIX
NuGet.VisualStudio.Client.clientenabledpkg
System.Buffers.dll
System.Memory.dll
System.Numerics.Vectors.dll
System.Runtime.CompilerServices.Unsafe.dll

Flattened directory content files used for comparison:
dev branch files.txt
this branch fe0f5e1ed files.txt

Special thanks to @jeffkl for helping address the above side effects with his MS Build expertise :)

PR Checklist

• Meaningful title, helpful description and a linked NuGet/Home issue
• Added tests - N/A - I tested that the VSIX builds, installs, and can open PM UI.
• Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

[jeffkl]

🎉

[zivkan]

I'd just like to confirm if someone downloaded the vsix from the dev branch, and from this branch, and validated that the files in both vsix's are the same?

[donnie-msft]

I did, and they are not. See these commits:

[zivkan]

Is the PR ready to be reviewed and merged, or is it still being worked on while the file differences are still being worked on?

When this PR pops up in my notification list, I'm not sure if I should review and approve, or if I should wait.

[donnie-msft]

It is ready for review. Sorry for the noise in the past day or so, we kept thinking it was done but little things kept cropping up. It appears my build is green which is why I'm updating the description now.

[donnie-msft]

I added a nifty table.

[donnie-msft]

When this PR pops up in my notification list, I'm not sure if I should review and approve, or if I should wait.

Open to suggestions. Even if I had put it back to a draft, you'll still get those notifications as GitHub does not unsubscribe anyone.

[zivkan]

yes, but if I see a notification for a draft PR, I can immediately move on, knowing I'll get another notification when it's ready for review, at which time I should look at the diff.

[jeffkl]

🎉