Upload binary logs in CI for cancellations #6080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
added
the
Engineering
donnie-msft
previously approved these changes
Oct 3, 2024
zivkan
previously approved these changes
Oct 3, 2024
jeffkl
force-pushed
the
dev-jeffkl-ci-binlogs-on-cancellation
branch
from
7a876fb
to
038152b
Compare
jeffkl
force-pushed
the
dev-jeffkl-ci-binlogs-on-cancellation
branch
from
038152b
to
18f1c11
Compare
|
Alright, success! The binary logs are incomplete due to cancellation but the VS test diagnostics showed that one test ran for 50 minutes before the test run was cancelled: I've opened a separate issue for that: https://github.com/NuGet/Client.Engineering/issues/3045 |
martinrrm
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Description
This change includes publishing of logs when a CI job is cancelled, particularly for when a test run times out. The binary logs might be incomplete but the VS Test diagnostic logs shows all of the output from xunit including long running tests, communication errors, etc.
PR Checklist