Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run tests in isolation #6105

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Do not run tests in isolation #6105

merged 1 commit into from
Oct 18, 2024

Conversation

jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Oct 17, 2024

Bug

Fixes:

Description

When you specify environment variables in a RunSettings file, I noticed this in the docs:

Because these environment variables should always be set when the test host is started, the tests should always run in a separate process. For this, the /InIsolation flag will be set when there are environment variables so that the test host is always invoked.

So this change sets the environment variable in the pipeline YAML instead which could improve our test run times. Supposedly this can make tests run a little slower but I wonder if its also contributing to test runs hanging/timing out. This mainly just removes a layer of complexity.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@jeffkl jeffkl added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Oct 17, 2024
@jeffkl jeffkl self-assigned this Oct 17, 2024
@jeffkl jeffkl marked this pull request as ready for review October 18, 2024 04:25
@jeffkl jeffkl requested a review from a team as a code owner October 18, 2024 04:25
Copy link
Contributor

@donnie-msft donnie-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth trying!

@jeffkl jeffkl merged commit 0b602b9 into dev Oct 18, 2024
30 of 32 checks passed
@jeffkl jeffkl deleted the dev-jeffkl-no-test-isolation branch October 18, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Changes related to the build infrastructure of the repo and that do not change product code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants