Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Test: Fix solution folder name comparison #6106

Merged
merged 2 commits into from
Oct 18, 2024
Merged

E2E Test: Fix solution folder name comparison #6106

merged 2 commits into from
Oct 18, 2024

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Oct 17, 2024 •
edited
Loading

Bug

Fixes:

Description

This fixes a good chunk of the E2E tests.
Creating folders/subfolders and retrieving them was broken.
This brings the failing down from 64 to 50

Run Group #1 - 41 to 37 failures
Run Group #2 - 23 to 13 failures

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@nkolev92 nkolev92 marked this pull request as ready for review October 18, 2024 00:23
@nkolev92 nkolev92 requested a review from a team as a code owner October 18, 2024 00:23
@nkolev92 nkolev92 added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Oct 18, 2024
donnie-msft
donnie-msft approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@donnie-msft donnie-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, such a simple change for such amazing impact. Nice find!

Btw, not sure what your description is linking to, but I don't think it's right. Also wasn't clear what the "41 to 37" meant.

@nkolev92
Copy link
Member Author

I've clarified the description.
There's 2 runs of E2E tests in the CI, so one group went from 41 failures to 37, while the other went from 23 to 13.

@nkolev92 nkolev92 enabled auto-merge (squash) October 18, 2024 16:08
@nkolev92 nkolev92 merged commit d67fa5b into dev Oct 18, 2024
31 of 33 checks passed
@nkolev92 nkolev92 deleted the dev-nkolev92-fixSolutionFolderName branch October 18, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkl jeffkl jeffkl approved these changes

@donnie-msft donnie-msft donnie-msft approved these changes

Assignees
No one assigned
Labels
Engineering Changes related to the build infrastructure of the repo and that do not change product code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkolev92 @jeffkl @donnie-msft