This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
China CDN log fix + minor global CDN log fix #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agr
requested review from
loic-sharma,
cristinamanum,
dannyjdev,
drewgillies,
joelverhagen,
lyndaidaii,
ryuyu,
shishirx34,
skofman1,
xavierdecoster and
zhhyu
loic-sharma
reviewed
Dec 9, 2020
tests/Tests.Stats.CollectAzureChinaCDNLogs/ChinaCollectorTests.cs
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Dec 9, 2020
loic-sharma
approved these changes
Dec 9, 2020
cristinamanum
approved these changes
Dec 9, 2020
dannyjdev
approved these changes
Dec 9, 2020
lyndaidaii
reviewed
Dec 9, 2020
lyndaidaii
approved these changes
Dec 9, 2020
removed extra spaces. Co-authored-by: lyndaidaii <64443925+lyndaidaii@users.noreply.github.com>
shishirx34
approved these changes
Dec 11, 2020
17 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/NuGet/Engineering/issues/3548
Some time ago China CDN logs started to use spaces in user agent string (before that those were replaced with
+), which were left unquoted by the CollectAzureChinaCDNLogs, which causes incorrect parsing of user agent in logs coming from China CDN.Also, while at it I had removed the code that added trailing space to all logs coming from global CDN and replaced bunch of string concatenations (that cause memory allocation on each call) with utilizing
StringBuilder.Appendwhich was already present anyway.