Issue #431 - moved owner names out of disabled textbox and into paragraph #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A little blog post to go along with this that might help explain: http://crosscuttingconcerns.com/Web-accessibility-contrast |
|
Looks fine to me. In future, could you provide a screenshot when making UI change Pull Requests? Thanks so much for the help! |
analogrelay
added a commit
that referenced
this pull request
Mar 13, 2014
…ntactOwnersPage Issue #431 - moved owner names out of disabled textbox and into paragraph
|
Can do. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #431 by taking owner names out of input box (which is NotUsed for input anyway) and into a plain paragraph to improve contrast. Threw in
<strong />just for good measure.