Merge dev into feature-redesign #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ReleasePrep][2017.05.19]RI of dev into master
Fixes #4002. Relevant to [VSTS #395879](https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=395879&_a=edit). This help-text bug was for the sign-in page, but this also affects the Report Abuse page. * Fixed accessibility of email field in report abuse page * Fixed signature accessibility
* Added Nuget.Services.Logging; moved to TelemetryResponseCodeProcessor * Added binding redirect for AI
* adding new optional semVerLevel query parameter to v2 odata endpoints * adding new optional semVerLevel query parameter to v2 autocomplete endpoints * Applying semVerLevel filter on v2 OData endpoints * Use [FromUri] attribute on semVerLevel (avoids having single quotes in the parameter value) * Ensure navigation links on v2 feeds use normalized version * Clarifying comment on Get(Id=,Version=) v2 API * Properly default to semver2 inclusion on Get(Id=,Version=) * Compare NormalizedVersion to be able to retrieve matching SemVer2 package versions for a given normalized version string. * Code review feedback * Update and fix broken test data
…ns (#3761) * Keep legacy version compatibility checks in place for non-semver2 versions * Added comment to clarify the reasons behind the legacy version check. * Fix typo * Rename test for clarity * code review feedback
…equesting a specific version, and compare on NormalizedVersion
Phase 2 of SemVer2 support
Merge dev into master - SemVer2
FI master->dev
- Added inline confirmation when adding new package owner - Added package URL link to package owner request emails - Added new notification to co-owners when package owner request is confirmed - Added secure push policy messaging to communication above (confirmation, request, and notification) - Added secure push policy messaging to package view for owners and admins - Fixed bug on security policy admin view where toggle all broken if multiple subscriptions - Updated security policy admin view to not reload page on update postback
# Conflicts: # content/PROD/Home.html # src/NuGetGallery/Queries/AutoCompleteDatabasePackageVersionsQuery.cs # src/NuGetGallery/Services/PackageService.cs # src/NuGetGallery/Strings.Designer.cs # src/NuGetGallery/Strings.resx # src/NuGetGallery/Views/Packages/DisplayPackage.cshtml # src/NuGetGallery/Views/Packages/ReportAbuse.cshtml # src/NuGetGallery/Views/Statistics/_PivotTable.cshtml # src/NuGetGallery/Views/Users/Profiles.cshtml # tests/NuGetGallery.Facts/Controllers/PackagesControllerFacts.cs # tests/NuGetGallery.Facts/Services/PackageServiceFacts.cs
joelverhagen
requested review from
loic-sharma,
xavierdecoster,
ryuyu,
chenriksson and
scottbommarito
xavierdecoster
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observe the last commit to verify merge conflicts.