Fix logging exceptions from background thread #6273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
previously approved these changes
Aug 7, 2018
joelverhagen
reviewed
Aug 7, 2018
| @@ -34,7 +37,7 @@ protected override Task SendMessageAsync(MailMessage mailMessage) | |||
| catch (Exception ex) | |||
| { | |||
| // Log but swallow the exception. | |||
| QuietLog.LogHandledException(ex); | |||
| telemetryService.TrackException(ex, _ => { }); | |||
There was a problem hiding this comment.
why not use the overload that doesn't require an Action?
|
We have a monitor on exception in Elmah which can trigger when exceptions go over a certain point. Since we know |
shishirx34
approved these changes
Aug 7, 2018
The previous code would try to resolve a service from DI in a background thread without a HttpContext, and Autofac would throw an exception. So, pass the required service to the background thread when it can be resolved.
zivkan
force-pushed
the
zivkan-background-mail-exceptions
branch
from
23e8c69
to
e44825c
Compare
zivkan
changed the title
joelverhagen
reviewed
Aug 7, 2018
| } | ||
|
|
||
| private ErrorLog errorLog; |
joelverhagen
approved these changes
Aug 7, 2018
zivkan
added a commit
that referenced
this pull request
Aug 9, 2018
zivkan
added a commit
that referenced
this pull request
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuietLog uses Elmah, which uses DI resolving at log time, rather than being contructed at HTTP request time. Autofac MVC's lifetime manager requires a HttpContext, which is null in a background thread, so there was no good/easy way to resolve the Elmah logger in a background thread. Logging only to app insights instead.