Set the CacheControl property on stored blobs #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
joelverhagen,
agr,
xavierdecoster,
shishirx34,
zivkan,
ryuyu,
dtivel,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
| @@ -318,6 +318,7 @@ public async Task SaveFileAsync(string folderName, string fileName, Stream file, | |||
| } | |||
|
|
|||
| blob.Properties.ContentType = GetContentType(folderName); | |||
| blob.Properties.CacheControl = CoreConstants.DefaultCacheControl; | |||
There was a problem hiding this comment.
Is this adding cache control to all files saved to blob storage in the gallery? Or just packages?
There was a problem hiding this comment.
This affects all uploaded blobs for all blob containers.
There was a problem hiding this comment.
I changed this to only affect the packages container.
| switch (folderName) | ||
| { | ||
| case CoreConstants.PackagesFolderName: | ||
| return CoreConstants.DefaultCacheControl; |
There was a problem hiding this comment.
nit: PackageCacheControl instead of Default
joelverhagen
approved these changes
Aug 11, 2018
| @@ -549,6 +550,7 @@ private static string GetContentType(string folderName) | |||
| case CoreConstants.PackageReadMesFolderName: | |||
| return CoreConstants.TextContentType; | |||
|
|
|||
| case CoreConstants.ContentFolderName: | |||
| case CoreConstants.RevalidationFolderName: | |||
There was a problem hiding this comment.
Why this addition? A test should cover it.
There was a problem hiding this comment.
The the content type tests skipped ContentFolderName, which caused it to fail my new test. I'll fix the content type test.
scottbommarito
approved these changes
Aug 13, 2018
dtivel
approved these changes
Aug 13, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the
CacheControlproperty on all packages blobs to 2 minutes.Fixes #6285