Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Don't attempt to send emails if they have no recipients #6638

Merged
merged 8 commits into from
Nov 8, 2018
Merged

Hotfix: Don't attempt to send emails if they have no recipients #6638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
830440e
only rev package version
Nov 8, 2018
d4403c8
bump to latest version
Nov 8, 2018
f584cce
Revert "bump to latest version"
Nov 8, 2018
58311f9
Revert "Revert "bump to latest version""
Nov 8, 2018
7e5289c
Revert "Revert "Revert "bump to latest version"""
Nov 8, 2018
fb2a83c
Revert "Revert "Revert "Revert "bump to latest version""""
Nov 8, 2018
32f0f2b
Revert "Revert "Revert "Revert "Revert "bump to latest version"""""
Nov 8, 2018
38b2a1c
Revert "Revert "Revert "Revert "Revert "Revert "bump to latest versio…
Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions src/NuGetGallery.Core/NuGetGallery.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,8 @@
<EmbeddedResource Include="Infrastructure\MigrateUserToOrganization.sql" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="NuGet.Services.Entities">
Copy link
Contributor Author

@scottbommarito scottbommarito Nov 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed these dependencies because they are transitively pulled in by NuGet.Services.Messaging.Email. I thought having this single dependency to rev will make this easier to manage in the future.

I have no problem with reverting this back if you think this isn't a good idea.

<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Messaging">
<Version>2.31.0</Version>
<PackageReference Include="NuGet.Services.Messaging.Email">
<Version>2.36.0-master-2190850</Version>
</PackageReference>
<PackageReference Include="NuGet.StrongName.AnglicanGeek.MarkdownMailer">
<Version>1.2.0</Version>
Expand Down Expand Up @@ -241,12 +238,6 @@
<PackageReference Include="NuGet.Packaging">
<Version>4.8.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Validation">
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Validation.Issues">
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="WindowsAzure.Storage">
<Version>7.1.2</Version>
</PackageReference>
Expand Down
9 changes: 0 additions & 9 deletions src/NuGetGallery/NuGetGallery.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1982,15 +1982,6 @@
<PackageReference Include="Markdig.Signed">
<Version>0.15.4</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Entities">
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Messaging">
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Messaging.Email">
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.StrongName.AnglicanGeek.MarkdownMailer">
<Version>1.2.0</Version>
</PackageReference>
Expand Down