Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken package delete #6642

Merged
merged 6 commits into from
Nov 8, 2018
Merged

Fix for broken package delete #6642

merged 6 commits into from
Nov 8, 2018

Conversation

agr
Copy link
Contributor

@agr agr commented Nov 8, 2018

Added new folder to a list of known private folders.
Changed the default cache control to be not set.
Updated tests to include the new folder.

To prevent the issue in the future all folders were moved into their own class and added a test that makes sure CloudBlobCoreFileStorageServiceFacts have all of them covered.

@agr agr merged commit 51ca9a7 into dev Nov 8, 2018
@agr agr deleted the agr-package-delete-fix branch November 8, 2018 23:58
scottbommarito pushed a commit that referenced this pull request Nov 9, 2018
* Package delete was broken with recent update. This fixes it.

* Moved folder names into its own class.
Updated tests to include All folders.

* Added tests to verify all folders are covered by tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants