Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Increase migration's database timeout #8052

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Conversation

loic-sharma
Copy link
Contributor

@loic-sharma loic-sharma commented Jun 17, 2020

We added a migration to add an index on the PackageDependencies table. This migration takes longer than 30 seconds to run on PROD and is timing out. This change increases the timeout to 30 minutes which we hope is enough to create the new index.

Verified on DEV:

Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3820287&view=results
Release: https://devdiv.visualstudio.com/DevDiv/_releaseProgress?_a=release-pipeline-progress&releaseId=712036

@zhhyu
Copy link
Contributor

zhhyu commented Jun 17, 2020

Maybe we want to make this a configured value later. But it should be good enough now.

@loic-sharma loic-sharma marked this pull request as ready for review June 17, 2020 22:21
@loic-sharma
Copy link
Contributor Author

@zhhyu Good idea, I created a new issue here: #8053

@loic-sharma loic-sharma merged commit 84ea589 into master Jun 17, 2020
@loic-sharma loic-sharma deleted the migration-hotfix branch June 17, 2020 22:29
zhhyu added a commit that referenced this pull request Jun 30, 2020
We added a migration to add an index on the `PackageDependencies` table. This migration takes longer than 30 seconds to run on PROD and is timing out. This change increases the timeout to 30 minutes which we hope is enough to create the new index.

Co-authored-by: Loïc Sharma <sharma.loic@gmail.com>
lyndaidaii added a commit that referenced this pull request Oct 8, 2020
* [HOTFIX] Increase migration's database timeout (#8052)

We added a migration to add an index on the `PackageDependencies` table. This migration takes longer than 30 seconds to run on PROD and is timing out. This change increases the timeout to 30 minutes which we hope is enough to create the new index.

* path fix in scritp point to vs2019 (#8244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants