-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage edit documentation #8169
Changes from all commits
43fbde3
61fd2b4
fbd7e26
1ea8907
073cf99
651cc6b
8998d5a
efd979d
15d9c0e
0fad9c9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,6 +50,7 @@ public VersionReadMeState(string submitUrl, string getReadMeUrl, string readMe) | |
public string SubmitUrl { get; } | ||
public string GetReadMeUrl { get; } | ||
public string ReadMe { get; } | ||
public bool HasEmbeddedReadme { get; set; } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you think whether it's better if we also set this value in the constructor, and restrict it to a read-only field? I see that we only use this field in the corresponding JS file, so it should be safe to do so? |
||
} | ||
|
||
/// <remarks> | ||
|
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -62,7 +62,7 @@ | |||
</div> | ||||
</div> | ||||
|
||||
@Html.Partial("_EditForm") | ||||
@Html.Partial("_EditForm", Model) | ||||
</div> | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to pass the model here? I see that we have passed the model:
|
||||
|
||||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use this property anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, it needs to be deleted