NuGet survey banner #8249
Merged
NuGet survey banner #8249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyndaidaii
requested review from
agr,
cristinamanum,
dannyjdev,
drewgillies,
joelverhagen,
loic-sharma,
ryuyu,
shishirx34,
skofman1,
xavierdecoster and
zhhyu
as code owners
lyndaidaii
force-pushed
the
lyn-survey-ban
branch
from
968587e
to
55383fd
Compare
loic-sharma
reviewed
Oct 8, 2020
| </span> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
I'd consider moving this to be the last banner, after the cookie and warning banners. I'm guessing the cookie banner needs to be the first thing on the page, is that correct @zhhyu?
loic-sharma
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Please double-check with @zhhyu about banner ordering before merging
Cookie banner should be on the top. I will move the survey banner after cookie and warning |
lyndaidaii
force-pushed
the
lyn-survey-ban
branch
from
55383fd
to
9eae6c8
Compare
lyndaidaii
added a commit
that referenced
this pull request
Oct 13, 2020
This reverts commit 53729e8.
lyndaidaii
added a commit
that referenced
this pull request
Oct 13, 2020
lyndaidaii
added a commit
that referenced
this pull request
Oct 16, 2020
lyndaidaii
added a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI:
Addresses #8225