Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add F# interactive instructions #8375

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Add F# interactive instructions #8375

merged 2 commits into from
Jan 13, 2021

Conversation

loic-sharma
Copy link
Contributor

@loic-sharma loic-sharma commented Jan 12, 2021 •
edited
Loading

@joelverhagen
Copy link
Member

Can you put a screenshot in the description?

@loic-sharma
Copy link
Contributor Author

@joelverhagen Added!

joelverhagen
joelverhagen approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure it looks at least usable/reasonable at smaller resolutions or windows sizes then :shipit:

@loic-sharma loic-sharma mentioned this pull request Jan 12, 2021
Closed
@loic-sharma
Copy link
Contributor Author

@joelverhagen I verified this is reasonably usable in a mobile view. Sadly, the tabs wrap onto a new line:

image

This is existing behavior though on nuget.org:

image

I don't plan to fix this as part of this change.

@joelverhagen
Copy link
Member

I've noticed this wrapping before and frankly, it's not that bad. Perhaps we could use a bit of polish there but it's still quite usable. The command itself wraps nicely so I'm happy with that if you are :)

@loic-sharma loic-sharma merged commit 1d671e0 into dev Jan 13, 2021
@loic-sharma loic-sharma deleted the loshar-fsharp-interactive branch January 13, 2021 22:47
@zhhyu zhhyu mentioned this pull request Jan 28, 2021
Closed
17 tasks
@filipw filipw mentioned this pull request Jan 29, 2021
Merged
@skofman1 skofman1 mentioned this pull request Apr 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel left review comments

@cartermp cartermp cartermp left review comments

@joelverhagen joelverhagen joelverhagen approved these changes

@zhhyu zhhyu zhhyu approved these changes

@agr agr Awaiting requested review from agr

@cristinamanum cristinamanum Awaiting requested review from cristinamanum

@dannyjdev dannyjdev Awaiting requested review from dannyjdev

@drewgillies drewgillies Awaiting requested review from drewgillies

@lyndaidaii lyndaidaii Awaiting requested review from lyndaidaii

@ryuyu ryuyu Awaiting requested review from ryuyu

@shishirx34 shishirx34 Awaiting requested review from shishirx34

@skofman1 skofman1 Awaiting requested review from skofman1

@xavierdecoster xavierdecoster Awaiting requested review from xavierdecoster

@jcjiang jcjiang Awaiting requested review from jcjiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loic-sharma @joelverhagen @baronfel @cartermp @zhhyu