[Redesign] Improve Lighthouse score #8707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
Jul 27, 2021
| @@ -1056,7 +1060,7 @@ | |||
| <i class="ms-Icon ms-Icon--FabricFolderSearch" aria-hidden="true" aria-label="@disclaimer" title="@disclaimer"></i> | |||
| <a href="@Model.NuGetPackageExplorerUrl" data-track="outbound-nugetpackageexplorer-url" | |||
| aria-label="open in NuGet Package Explorer" | |||
| title="Explore additional package info on NuGet Package Explorer" target="_blank" rel="nofollow"> | |||
| title="Explore additional package info on NuGet Package Explorer" target="_blank" rel="nofollow noreferrer"> | |||
There was a problem hiding this comment.
This improves privacy and security.
See: https://stackoverflow.com/questions/50773152/when-should-i-use-rel-noreferrer
See: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel
rel value |
Description |
|---|---|
| nofollow | Indicates that the current document's original author or publisher does not endorse the referenced document. |
| noreferrer | No Referer header will be included. Additionally, has the same effect as noopener. |
| noopener | Creates a top-level browsing context that is not an auxiliary browsing context if the hyperlink would create either of those, to begin with (i.e., has an appropriate target attribute value). |
loic-sharma
commented
Jul 27, 2021
| @if (!Model.Owners.Any()) | ||
| { | ||
| @ViewHelpers.AlertWarning(@<text>This package has no owners and is not being actively maintained.</text>) | ||
| } |
There was a problem hiding this comment.
Previously we would nest a <div> in a <ul> if the package had owners. That is not a best practice
loic-sharma
commented
Jul 27, 2021
| @@ -137,6 +137,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| @section Meta { | |||
| <meta name="description" content="@Model.ShortDescription"> | |||
There was a problem hiding this comment.
This improves our SEO
dannyjdev
approved these changes
Jul 27, 2021
zhhyu
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lighthouse is a tool to check a website follows best practices: https://developers.google.com/web/tools/lighthouse
Remaining issues I did not address:
fabric.css.Addresses #8605