[Redesign] Fix Safari font issue #8723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
Jul 29, 2021
| @@ -174,7 +174,6 @@ | |||
|
|
|||
| .instructions-displayed { | |||
| background-color: #FAF9F8; | |||
| font-family: 'Segoe UI'; | |||
There was a problem hiding this comment.
This isn't necessary. The default font is Segoe UI with default fallbacks:
font-family: 'Segoe UI', "Helvetica Neue", Helvetica, Arial, sans-serif
zhhyu
approved these changes
Jul 29, 2021
dannyjdev
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari does not support the Segoe UI font and falls back to the next font. This does not affect Chrome, Firefox, Edge, Internet Explorer, Opera
Before 🤮
After 💪
Addresses #8722
Test build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5037774&view=results
Test release: https://devdiv.visualstudio.com/DevDiv/_releaseProgress?_a=release-pipeline-progress&releaseId=1115031