Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Change role attribute of Recaptcha iframe #9306

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

advay26
Copy link
Member

@advay26 advay26 commented Nov 11, 2022

Addresses #9300

Problem:

Th Recaptcha iframes on pages like the Forgot Password page and the Report Abuse page were marked with the role presentation by default, but this role (as well as the none role) disables some accessibility properties, which is why FastPass was flagging it.

Previously,
iframe before

Fix:

Iframes are only allowed to be marked with the roles document, application or img (also presentation or none, but that causes other a11y problems). I changed the role of this iframe to document, and it clears FastPass checks now (on both the pages flagged in the bug, the Forgot Password page and the Report Abuse page).

After the changes,
iframe after

@advay26 advay26 requested a review from a team as a code owner November 11, 2022 00:19
Copy link
Contributor

@ryuyu ryuyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the looks of the properties here, tab order should still be ok (the original reason we made changes here), but can we do a quick verification that tab order is still ok? Otherwise, looks great!

@advay26 advay26 merged commit 41a7375 into dev Nov 11, 2022
@advay26 advay26 deleted the dev-advay26-a11y-recaptcha branch November 11, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants