Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search page A11y fixes #9387

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Search page A11y fixes #9387

merged 2 commits into from
Feb 13, 2023

Conversation

advay26
Copy link
Member

@advay26 advay26 commented Feb 10, 2023

  1. This PR fixes an accessibility issue where, when the TFM section was collapsed and there were very few search results on the page, the black text of some of the TFM checkbox labels could overlap with the dark blue footer background (even though the checkboxes were not visible), causing a contrast issue on A11y FastPass.
    image
    We now flip the TFM tab's display property between 'none' and 'block' when it is collapsed or expanded. This also means we don't need to manually toggle tabindex for the checkboxes when the section is collapsed or expanded.

  2. The text we show when there's 0 package results also has an a11y issue, where it shouldn't have the aria-expanded property. I've removed that now.
    image

  3. I've also removed an unused ViewModel property (ShouldDisplayAdvancedSearchPanel).

@advay26 advay26 requested a review from a team as a code owner February 10, 2023 21:21
@advay26 advay26 merged commit 9111502 into dev Feb 13, 2023
@advay26 advay26 deleted the dev-advay26-sbtfm-a11y branch February 13, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants