Added null checks to mitigate exceptions on the '/profiles' pages

[advay26]

The /profiles pages use the same js script as the search page, but do not have a searchForm element on the page, so we were getting exceptions from the javascript on the /profiles pages when we tried to reference the form elements.

I've now added checks in the script so that we do not reference anything that doesn't exist on the page.

I also removed a helper method that was not being used by the search page anymore (AddSortByOption()).

[zhhyu]

typeof searchForm.sortby != "undefined"

I am not a JS expert. Is that necessary to check this? or just checking 'searchForm' is enough?

[joelverhagen]

Furthermore you can simplify the code by just checking if searchForm is falsy, like if (searchForm).

[advay26]

I've changed to code to check using just if (searchForm) now. Thanks!

[zhhyu]

searchForm.sortby.addEventListener

Does that work if we only check once but register them under one block?

Something like:

if (typeof searchForm != "undefined") {
    searchForm.sortby.addEventListener('change', (e) => {
        searchForm.sortby.value = e.target.value;
        submitSearchForm();
    });
    searchForm.addEventListener('submit', submitSearchForm);
    initializeFrameworkAndTfmCheckboxes();
}

Please ignore if it doesn't help.

[advay26]

This makes sense and looks much cleaner, so I've put them all in one block. We only need to check if (searchForm) for all of them.