Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Search page a11y fixes for tags and framework filter buttons #9429

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

advay26
Copy link
Member

@advay26 advay26 commented Mar 14, 2023

Addresses #9402, #9412 and #9413

This PR fixes 3 a11y issues:

  1. The tags in search results sometimes appeared on the same line as the other package metadata (version, last created, etc.) and sometimes appeared on the next line. We wanted to make this consistent and always have the 'tags' on the next line, but adding a <br> element in the middle of a list led to this a11y issue:
    image

    I've now removed the <br> element and fixed this with some css:
    image

  2. The chevrons that expanded/collapsed the TFM sections in the Filters panel did not indicate their expanded/collapsed state. The screen reader should be able to read their state. The 'aria-expanded' can be used to fix this.

  3. These chevrons also all had the same 'aria-label': "shows and hides TFM filters". I've now made each button's label relevant to its specific frameworks: eg. "shows and hides TFM filters for .NET Standard".

@advay26 advay26 requested a review from a team as a code owner March 14, 2023 20:58
joelverhagen
joelverhagen previously approved these changes Mar 15, 2023
Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about CSS cascading

@advay26 advay26 merged commit 6e8f5ea into dev Mar 16, 2023
@advay26 advay26 deleted the dev-advay26-a11y branch April 4, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants