This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Improve NuGet CLI behaviour when running as global tool #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This returns to the old behaviour, that was still expected by the consumers of this class.
NuKeeper/Engine/RepositoryUpdater.cs
Outdated
| @@ -97,7 +98,11 @@ public class RepositoryUpdater : IRepositoryUpdater | |||
| return 0; | |||
| } | |||
|
|
|||
| await _solutionsRestore.Restore(git.WorkingFolder, sources); | |||
| if (targetUpdates.SelectMany(u => u.CurrentPackages) | |||
| .Any(p => p.Path.PackageReferenceType != PackageReferenceType.ProjectFile)) | |||
There was a problem hiding this comment.
I would extract a helper fn, e.g. AnyProjectRequiesNugetRestore
AnthonySteele
approved these changes
Aug 23, 2018
AnthonySteele
added a commit
that referenced
this pull request
Aug 25, 2018
* Generic topo sort * Sortings * Improve NuGet CLI behaviour when running as global tool (#402) * Log error instead of throwing when NuGet cli cannot be found. This returns to the old behaviour, that was still expected by the consumers of this class. * Do not run global nuget restore when dealing with a dotnetcore-only project. * Include NuGet.exe in packaged tool * Expanded diagnostic output when probing for NuGet.exe location * NuGetFileRestoreCommand created by IoC * NuGetUpdatePackageCommand created by IoC * DotNetUpdateCommand created by IoC * UpdateProjectImportsCommand created by IoC * UpdateNuspecCommand created by IoC * Extract helper method to improve readability * Cache the path to NuGet.exe when found * Delay evaluation of NuGetPath so that it happens after logger is configured * Generic topo sort * Sortings * Started sorter tests * Test sort logger output * Actual sort tests * Fix integration bug * A test on the "GetFullPath" line * test sort with bad inout data cycle * More PackageUpdateSetTopologicalSortTests better test asserts * cycle detection for PackageUpdateSet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400