Skip to content

Commit

Permalink
change: Don't compress windows binaries
Browse files Browse the repository at this point in the history
Binaries that're compressed via upx tend to trigger the windows
defender and other anti-virus programs.

To prevent these false-positives, the windows binaries won't be
compressed any longer.

Fixes #421
  • Loading branch information
Nukesor committed Mar 14, 2023
1 parent e97d9b4 commit 78a9b05
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/package-binary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,15 @@ jobs:
file: ${{ matrix.client_artifact_name }}
args: --lzma
strip: ${{ matrix.strip }}
if: matrix.target != 'x86_64-pc-windows-msvc'

- name: Compress daemon
uses: svenstaro/upx-action@v2
with:
file: ${{ matrix.daemon_artifact_name }}
args: --lzma
strip: ${{ matrix.strip }}
if: matrix.target != 'x86_64-pc-windows-msvc'

- name: Upload client binaries to release
uses: svenstaro/upload-release-action@v2
Expand Down

0 comments on commit 78a9b05

Please sign in to comment.