Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic sockets && Unix Socket support #118

Merged
merged 13 commits into from
Oct 16, 2020
Merged

Generic sockets && Unix Socket support #118

merged 13 commits into from
Oct 16, 2020

Conversation

Nukesor
Copy link
Owner

@Nukesor Nukesor commented Oct 15, 2020

Resolves #90

This PR adds generic streams/listeners and support for UnixSockets.

What still needs to be done:

  • Move the socket code to the platform specific code
  • Make a unix platform for shared code between linux and macOs
  • On daemon start: Check whether he unix socket exists. If it exists, check if you can connect.
    If one can connect, abort and write an error message.
    If we cannot connect, remove the socket and continue normal operations.
  • Maybe get those generic Traits better names.

@Nukesor Nukesor added the t: Enhancement Something that exists, but could be made better label Oct 15, 2020
@Nukesor Nukesor self-assigned this Oct 15, 2020
@Nukesor Nukesor force-pushed the generic-sockets branch 2 times, most recently from a5a0b9e to 5962230 Compare October 15, 2020 21:55
@Nukesor Nukesor force-pushed the generic-sockets branch 2 times, most recently from 58857ac to f3d940d Compare October 15, 2020 22:05
@Nukesor Nukesor changed the title Generic sockets Generic sockets && Unix Socket support Oct 15, 2020
@Nukesor Nukesor merged commit b44c89f into master Oct 16, 2020
@Nukesor Nukesor deleted the generic-sockets branch October 18, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: Enhancement Something that exists, but could be made better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unix Socket support
1 participant