Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flaky tests with parallel tasks #368

Merged
merged 1 commit into from
Oct 1, 2022
Merged

fix: Flaky tests with parallel tasks #368

merged 1 commit into from
Oct 1, 2022

Conversation

Nukesor
Copy link
Owner

@Nukesor Nukesor commented Oct 1, 2022

The duration of the tasks in the worker_environment_variables test suite was too low, resulting in occasional flakes.

This should now be fixed, by making the tasks live longer.

This MR is mainly here to run this on the CI environment, as this only happens on potato machines.

@Nukesor Nukesor added the t: Bug label Oct 1, 2022
@Nukesor Nukesor self-assigned this Oct 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #368 (e6515b9) into main (027d6fa) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   77.16%   77.18%   +0.01%     
==========================================
  Files          71       71              
  Lines        4954     4957       +3     
==========================================
+ Hits         3823     3826       +3     
  Misses       1131     1131              
Impacted Files Coverage Δ
daemon/task_handler/mod.rs 90.26% <ø> (ø)
daemon/task_handler/messages/mod.rs 92.00% <100.00%> (+1.52%) ⬆️
daemon/network/message_handler/remove.rs 94.73% <0.00%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

The duration of the tasks in the worker_environment_variables test suite
was too low, resulting in occasional flakes.

This should now be fixed, by making the tasks live longer.
@Nukesor Nukesor force-pushed the fix-flaky-unix-test branch from e6515b9 to 4566a29 Compare October 1, 2022 17:42
@Nukesor Nukesor merged commit b0e6c35 into main Oct 1, 2022
@Nukesor Nukesor deleted the fix-flaky-unix-test branch October 1, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants