Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse all signal names #456

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Parse all signal names #456

merged 1 commit into from
Aug 21, 2023

Conversation

Nukesor
Copy link
Owner

@Nukesor Nukesor commented Aug 18, 2023

Fixes #455

@Nukesor Nukesor added the t: Enhancement Something that exists, but could be made better label Aug 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #456 (ec54381) into main (27a650e) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   79.52%   79.48%   -0.04%     
==========================================
  Files          79       77       -2     
  Lines        5420     5416       -4     
==========================================
- Hits         4310     4305       -5     
- Misses       1110     1111       +1     
Files Changed Coverage Δ
pueue_lib/src/network/message.rs 54.71% <ø> (ø)
pueue_lib/src/process_helper/mod.rs 35.71% <ø> (ø)
pueue/src/daemon/task_handler/finish_task.rs 76.08% <50.00%> (ø)
pueue/src/daemon/task_handler/messages/group.rs 68.75% <100.00%> (ø)

... and 5 files with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Test Results

    3 files  ±0    22 suites  ±0   2m 50s ⏱️ -5s
140 tests ±0  140 ✔️ ±0  0 💤 ±0  0 ±0 
300 runs  ±0  300 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 28a113e. ± Comparison against base commit 4cb610d.

♻️ This comment has been updated with latest results.

@Nukesor Nukesor force-pushed the parse-all-signal-names branch from ec54381 to c455fdd Compare August 18, 2023 09:54
@Nukesor Nukesor changed the base branch from main to development August 18, 2023 14:49
@Nukesor Nukesor force-pushed the parse-all-signal-names branch from c455fdd to 6fd6b2d Compare August 18, 2023 14:54
@Nukesor Nukesor force-pushed the parse-all-signal-names branch from 6fd6b2d to 28a113e Compare August 21, 2023 17:48
@Nukesor Nukesor merged commit 0b7aacd into development Aug 21, 2023
@Nukesor Nukesor deleted the parse-all-signal-names branch August 21, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: Enhancement Something that exists, but could be made better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept SIGINT, INT, and int along with sigint as a vallid signal name.
2 participants