Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support editing task priorities #490

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Conversation

jch-13
Copy link
Contributor

@jch-13 jch-13 commented Jan 11, 2024

Adds support for the modification of task priorities in a queue via pueue edit --priority/-o and pueue restart --edit-priority/-o (fixes #449). Despite the interesting discussion in #449 about how to improve task editing in general, this takes the easy way out and tries to integrate with the existing editing system by using (multiple) editor instances for now.

Checklist

  • I picked the correct source and target branch.
  • I included a new entry to the CHANGELOG.md.
  • I checked cargo clippy and cargo fmt. The CI will fail otherwise anyway.
  • (If applicable) I added tests for this feature or adjusted existing tests.
  • (If applicable) I checked if anything in the wiki needs to be changed.

Copy link
Owner

@Nukesor Nukesor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

It looks pretty clean, two minor nitpicks. I kind of let the feature stall since I wanted to fix this in a proper way, but I guess you're right. This is an good intermediate solution until there's a conclusion on how to move forward.

CHANGELOG.md Show resolved Hide resolved
pueue/tests/client/integration/edit.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fb6caab) 79.61% compared to head (42af45a) 79.67%.

Files Patch % Lines
pueue/src/client/cli.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #490      +/-   ##
===============================================
+ Coverage        79.61%   79.67%   +0.05%     
===============================================
  Files               77       77              
  Lines             5538     5564      +26     
===============================================
+ Hits              4409     4433      +24     
- Misses            1129     1131       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 11, 2024

Test Results

  2 files  ±0   14 suites  ±0   1m 23s ⏱️ +7s
146 tests +2  146 ✅ +2  0 💤 ±0  0 ❌ ±0 
167 runs  +2  167 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 42af45a. ± Comparison against base commit fb6caab.

♻️ This comment has been updated with latest results.

Co-authored-by: Arne  Christian Beer <privat@arne.beer>
@jch-13
Copy link
Contributor Author

jch-13 commented Jan 11, 2024

Thank you! :)

@jch-13 jch-13 requested a review from Nukesor January 11, 2024 18:37
@jch-13 jch-13 mentioned this pull request Jan 15, 2024
5 tasks
@Nukesor Nukesor merged commit 3849beb into Nukesor:development Jan 15, 2024
19 checks passed
@Nukesor
Copy link
Owner

Nukesor commented Jan 15, 2024

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants