-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support editing task priorities #490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR :)
It looks pretty clean, two minor nitpicks. I kind of let the feature stall since I wanted to fix this in a proper way, but I guess you're right. This is an good intermediate solution until there's a conclusion on how to move forward.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #490 +/- ##
===============================================
+ Coverage 79.61% 79.67% +0.05%
===============================================
Files 77 77
Lines 5538 5564 +26
===============================================
+ Hits 4409 4433 +24
- Misses 1129 1131 +2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Arne Christian Beer <privat@arne.beer>
Thank you! :) |
Thanks :) |
Adds support for the modification of task priorities in a queue via
pueue edit --priority/-o
andpueue restart --edit-priority/-o
(fixes #449). Despite the interesting discussion in #449 about how to improve task editing in general, this takes the easy way out and tries to integrate with the existing editing system by using (multiple) editor instances for now.Checklist
CHANGELOG.md
.cargo clippy
andcargo fmt
. The CI will fail otherwise anyway.